ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.86k stars 1.04k forks source link

Strange Brigade (312670) #920

Open Oliver-1xok opened 6 years ago

Oliver-1xok commented 6 years ago

The game Strange Brigade don't works on my system. It installs without problems. But after starting only a small black and non-movable window with unsteady border appears.

My System:

CPU: i7 6700k
GPU: GTX 970 
RAM: 16 GB
NVIDIA Driver Version: 396.54
Proton Version: proton-3.7beta-20180824
OS: Xubuntu 18.4. (Ubuntu with Xfce)

Maybe it would help like with Doom, if I enter a launch parameter, which starts the game directly with Vulkan. But I don't know such a launch parameter for this game.

AlexNigl commented 5 years ago

You can click slightly below the top left corner to start the game, where I drew the green box. strange_brigade

I have no audio but this is probably a separate issue.

GloriousEggroll commented 5 years ago

note: this still doesnt work with faudio, but installing xact to the prefix and using the xaudio2_7 override works

flibitijibibo commented 5 years ago

The latest FAudio deals with one issue where the submix ordering was wrong...

https://github.com/FNA-XNA/FAudio/commit/8e0883d9b3e3d0dedde83a234eb93e551b9b4a4f

... but I've narrowed down the hideous noise to one of the submix effects. If you comment out this block, the sound is okay:

https://github.com/FNA-XNA/FAudio/blob/master/src/FAudio_internal.c#L1005

I have no idea what the problem effect in question is, but if it's an effect in the engine and not one of ours, we could be in trouble...

flibitijibibo commented 5 years ago

Well, this isn't good. Out of the 7 unique effects I was able to identify, none of them are known effects. They're not ours and the CLSIDs are not familiar to me at all.

It seems like we're doing everything right; all the flags are accounted for, LockForProcess succeeds, and the effect in question is in-place so there shouldn't be any uninitialized memory (the bug sounds the same every time, FWIW). The only thing I can possibly think of is parameter update accuracy, but without access to the effects I have no idea if that's relevant.

Point being, it's somewhere in either SetEffectChain (FAudio.c) or ProcessEffectChain (FAudio_internal.c) but that's all I know.

flibitijibibo commented 5 years ago

Out of random curiosity I decided to add support for the SILENT flag in the XAPO spec and... uh, it sounds okay now?

https://github.com/FNA-XNA/FAudio/commit/5f8e1f0bc71867dca5310143bc3ceecc778023fd EDIT: Did I really think f32 PCM would never be < 0...

I don't feel like this should make sense, but I did notice that they don't set their effect parameters until 1 update after it starts processing, so maybe it's a very specific case where silence initializes some stuff and by the time real sound starts pushing out, it coincidentally happens to be ready for real samples. I'm completely fabricating that idea though, so if you try upstream FAudio be on the lookout for more screeching.

flibitijibibo commented 5 years ago

3.16-6 includes the latest FAudio, should resolve sound issues for this title.

gort818 commented 5 years ago

Strange brigade runs great now using the vulkan exe. getting an avg of 90fps on vega 56 ultra @1440p. Audio works perfectly now thanks!

darksithk8 commented 5 years ago

Hello everyone. I have similar issue with running game Strange Brigade on Ubuntu system. When game loads then goes back to desktop.

I have fresh install of Ubuntu: Description: Ubuntu 18.04.1 Bionic LTS I have everything up to date. Using Proton 3.16-6 Beta.

This is my PC hardware [Lenovo Y720]:

                     system         80VR (LENOVO_MT_80VR_BU_idea_FM_Y720-15

/0 bus LNVNB161216 /0/0 memory 128KiB BIOS /0/4 processor Intel(R) Core(TM) i5-7300HQ CPU @ 2.50G /0/24/0 memory 8GiB SODIMM DDR4 Synchronous Unbuffered /0/100 bridge Intel Corporation /0/100/1 bridge Skylake PCIe Controller (x16) /0/100/1/0 display GP106M [GeForce GTX 1060 Mobile] /0/100/2 display Intel Corporation /0/100/14 bus Sunrise Point-H USB 3.0 xHCI Controller /0/100/14/0 usb1 bus xHCI Host Controller /0/100/14/0/8 generic Xbox Embedded Wireless /0/100/14/0/9 input ITE Device(8910) /0/100/14/0/b communication Bluetooth wireless interface /0/100/14/1 usb2 bus xHCI Host Controller /0/100/14.2 generic Sunrise Point-H Thermal subsystem /0/100/15 generic Sunrise Point-H Serial IO I2C Controlle /0/100/15.2 generic Intel Corporation /0/100/16 communication Sunrise Point-H CSME HECI #1 /0/100/17 storage Sunrise Point-H SATA Controller [AHCI m /0/100/1c bridge Sunrise Point-H PCI Express Root Port # /0/100/1c/0 wlp2s0 network Wireless 8265 / 8275 /0/100/1c.3 bridge Sunrise Point-H PCI Express Root Port # /0/100/1c.3/0 enp3s0 network RTL8111/8168/8411 PCI Express Gigabit E /0/100/1c.4 bridge Sunrise Point-H PCI Express Root Port # /0/100/1d bridge Sunrise Point-H PCI Express Root Port # /0/100/1d/0 storage Non-Volatile memory controller /0/100/1f bridge Sunrise Point-H LPC Controller /0/100/1f.2 memory Memory controller /0/100/1f.3 multimedia Intel Corporation /0/100/1f.4 bus Sunrise Point-H SMBus sb github com valvesoftware proton issues 920b

kisak-valve commented 5 years ago

Hello @darksithk8, please add PROTON_LOG=1 %command% to the game's launch options and drag and drop the generated $HOME/steam-$APPID.log into the comment box.

darksithk8 commented 5 years ago

It's a lot of code: steam-312670.log

darksithk8 commented 5 years ago

Anyone?

NTMan commented 5 years ago

The game mostly playable if not enabled tessellation. With enabled tessellation even impossible select character because of graphics artifacts. I don't know which render are used by default (DX12 or Vulkan) so I can't say which are culprit here vkd3d or RADV driver. https://youtu.be/3qv2jGMWtlU

kisak-valve commented 5 years ago

Hello @NTMan, please add PROTON_LOG=1 %command% to the game's launch options and drag and drop the generated $HOME/steam-$APPID.log into the comment box. Also, please copy your system information from Steam (Steam -> Help -> System Information) and put it in a gist, then include a link to the gist in this issue report.

NTMan commented 5 years ago

Hello @NTMan, please add PROTON_LOG=1 %command% to the game's launch options and drag and drop the generated $HOME/steam-$APPID.log into the comment box. Also, please copy your system information from Steam (Steam -> Help -> System Information) and put it in a gist, then include a link to the gist in this issue report.

steam-312670.log System Information Strange Brigade benchmark with enabled tessellation

darksithk8 commented 5 years ago

@NTMan, but Mr. kisak-valve does not give solution to problem only collecting logs.. :(

hakzsam commented 5 years ago

The tessellation issue with RADV is fixed with: https://cgit.freedesktop.org/mesa/mesa/commit/?id=b155f74d7bfc9daec7794074c4f644025fbddf8b

The fix should be in the next 19.0 release (19.0.4) and it will be in 19.1 of course.

ryliejamesthomas commented 3 years ago

Audio-wise I'm getting nothing but noise. Is this what happened in earlier error reports?

edit: More research suggests this is actually an issue in Windows too, and disabling audio reverb via the launcher fixes it.

Oschowa commented 3 years ago

The launcher crashes again on latest Proton experimental 6.3-20210625. Proton 6.3-5 is fine. steam-312670.log

kisak-valve commented 3 years ago

Hello @Oschowa, your log looks similar to https://github.com/ValveSoftware/Proton/issues/980#issuecomment-869145030.

rbernon commented 3 years ago

The regression should be fixed in today's Experimental update, both games were affected.

Oschowa commented 3 years ago

Can confirm it's working again, thanks!