ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.92k stars 1.04k forks source link

Assassins Creed Origins (582160) #928

Open thaleslimao opened 6 years ago

thaleslimao commented 6 years ago

Under the games when clicking on play brings me the UPLAY login screen.

When adding my credentials always returns me error and I can not connect,

If anyone can simulate this scenario to see where exactly the error is, thank you.

Kubuntu 18.04

TheHaf commented 2 years ago

I have the same issue on my Steam Deck as @smintman, since patch 1.60 the game crashes shortly after loading a save. I noticed that when I stay longer in the menu before loading the game, the crash seems to happen sooner after loading it. Also I am using Bottles to start the Ubisoft launcher and the game. Anything I can do to try get to the bottom of this? Does it help if I provide a log and system info as well?

smintman commented 2 years ago

The freezing issue should be affecting steam deck owners that have the steam version now as its been updated? Can anyone that owns the steam version and a steamdeck confirm they have the freezing issue?

The issue appears to also be affecting windows users that use Windows 7, does anyone know of any settings we can use to make Origins run more like we are on a windows 10 machine?

MaCroX95 commented 2 years ago

@TheHaf I can confirm the issue, after the game update the hang occurs almost immidiately after loading the game, it doesn't however crash in benchmark, which is weird.

kakra commented 2 years ago

I can confirm the issue, after the game update the hang occurs almost immidiately after loading the game, it doesn't however crash in benchmark, which is weird.

@MaCroX95 Actually, it can hang at any time: I tried multiple times. One time it froze on the AC splash logo (that one where it says "press any key to start"), one time it just froze on the black screen before that logo, once it froze on the loading screen (where you can "walk" around after loading a game from the main menu), once it randomly froze during gameplay, and once I could play for 20+ minutes without any freezes. So there's no special scene where it freezes, it can happen any time, no matter if in game, in the main menu, or during intro logos.

vahidshirvani commented 2 years ago

Same here, freezes on my steamdeck

matt22207 commented 2 years ago

Free weekend on Ubisoft, and so of course they just broke it.

Same issue here running v1.60 of the game, freezes randomly on my:

vahidshirvani commented 2 years ago

Can you at least change the "playable" status to "unsupported" on the steam store for the time being? I am not able to stay in the game for 2 minutes before it crashes. Totally unplayable in my opion.

mercifulboss commented 2 years ago

Hello @smintman, please add PROTON_LOG=1 %command% to the game's launch options and attach the generated $HOME/steam-$APPID.log to this issue report as a file. (Proton logs compress well if needed.) Also, please copy your system information from Steam (Steam -> Help -> System Information) and put it in a gist, then include a link to the gist in this issue report.

Any updates on potential fixes for this game? @kisak-valve, it was bought on steam summer sale (according to previous information regarding this game working - neglected to check recently - after all why would single player game break?) but seems to be freezing now regardless of launch options or proton version used.

kakra commented 2 years ago

Maybe the game engine may have been updated to be more similar to AC:Odyssey, and so it maybe needs the same fix as AC:Odyssey?

OTOH, running with PROTON_NO_FSYNC=1 PROTON_NO_ESYNC=1 doesn't seem to help much. The game may run a little longer but that's it.

vahidshirvani commented 2 years ago

@ivyl Assassin's Creed Origins lately got an update which broke the game on Proton. Would you kindly investigate if your fix for AC Odyssey would also work on AC Origins as well?

papibaquigrafo4 commented 2 years ago

Same here, tried pretty much every option possible to make it run and nothing. The game always crash at some point in 5 minutes, ram, vram, swap, all seems reasonable. Heres the last lines of the log, it may help.

1652.934:0150:0630:trace:seh:NtGetContextThread 0xfffffffe: eax=000000d8 ebx=00000004 ecx=00000000 edx=00000000 esi=00000004 edi=2ea7f990
1652.934:0150:0630:trace:seh:NtGetContextThread 0xfffffffe: ebp=2ea7faa8 esp=2ea7f94c eip=7bc0bd9c cs=0023 ss=002b flags=00000246
1652.934:0150:0630:trace:seh:NtGetContextThread 0xfffffffe: ds=002b es=002b fs=0063 gs=006b
1652.934:0150:062c:fixme:rawinput:DefRawInputProc data 2DBFF9B8, data_count 1, header_size 16 stub!
1652.948:0150:062c:fixme:rawinput:DefRawInputProc data 2DBFF9B8, data_count 1, header_size 16 stub!
1652.948:0150:01f0:trace:seh:NtGetContextThread 0xfffffffe: eax=000000d8 ebx=00000004 ecx=00000000 edx=00000000 esi=00000004 edi=1ff3f990
1652.948:0150:062c:fixme:rawinput:DefRawInputProc data 2DBFF9B8, data_count 1, header_size 16 stub!
1652.948:0150:01f0:trace:seh:NtGetContextThread 0xfffffffe: ebp=1ff3faa8 esp=1ff3f94c eip=7bc0bd9c cs=0023 ss=002b flags=00000246
1652.948:0150:01f0:trace:seh:NtGetContextThread 0xfffffffe: ds=002b es=002b fs=0063 gs=006b
1652.950:0150:062c:fixme:rawinput:DefRawInputProc data 2DBFF9B8, data_count 1, header_size 16 stub!
1652.950:0150:062c:fixme:rawinput:DefRawInputProc data 2DBFF9B8, data_count 1, header_size 16 stub!
1694.523:03bc:0464:fixme:system:NtUserSystemParametersInfo Unimplemented action: 59 (SPI_SETSTICKYKEYS)
1694.523:03bc:0464:fixme:system:NtUserSystemParametersInfo Unimplemented action: 53 (SPI_SETTOGGLEKEYS)
1694.523:03bc:0464:fixme:system:NtUserSystemParametersInfo Unimplemented action: 51 (SPI_SETFILTERKEYS)
1694.532:0110:0124:fixme:oleacc:find_class_data unhandled window class: L"#32769"
1702.776:0110:0124:fixme:oleacc:find_class_data unhandled window class: L"#32769"
pid 7590 != 7589, skipping destruction (fork without exec?)
ivyl commented 2 years ago

Hi. We were unable to reproduce by simply running the game. Do you need to reach a certain point in the story for it to crash?

Also can someone share a full log of the crash? The snippet above doesn't contain anything that would help us pinpoint the issue.

smintman commented 2 years ago

Hi. We were unable to reproduce by simply running the game. Do you need to reach a certain point in the story for it to crash?

Also can someone share a full log of the crash? The snippet above doesn't contain anything that would help us pinpoint the issue.

The freeze is pretty random, sometimes it will happen on the initial Warning splash screen, sometimes it will happen after 5-10 mins of running about in the game, but about 5-10 mins, It seems the less you do in game the longer you can go..? What version of Origins are you running, if you've not updated yet that might be why it has not crashed for you version 1.5.1 works fine, but version 1.6 does not.

I posted some logs in this comment about this issue https://github.com/ValveSoftware/Proton/issues/928#issuecomment-1148648796

Also posted bug here just in case it was something the dvxk team could resolve, but in their troubleshooting he got me to try the PROTON_USE_WINED3D=1 renderer which also resulted in it eventually freezing.

https://github.com/doitsujin/dxvk/issues/2712

There are plenty of people with this issue, looking at the ubisoft and steam forums, issues reported by steamdeck users and windows 7 users, seems ok on windows 10?

Let me know if you need anything else?

vahidshirvani commented 2 years ago

I was never able to get passed the solders standing outside. Freezed before fight began. About 10min into the game.

Blisto91 commented 2 years ago

If it happens mostly at specific times during gameplay this probably wont do anything. But a couple of other random things to try. Disable overlays if possible, steam and uplay. Try playing without an internet connection incase it's because it sometimes tries to contact some outside service that fails in a horrible way. If the game has autosaving try disabling that if possible.

smintman commented 2 years ago

If it happens mostly at specific times during gameplay this probably wont do anything. But a couple of other random things to try. Disable overlays if possible, steam and uplay. Try playing without an internet connection incase it's because it sometimes tries to contact some outside service that fails in a horrible way. If the game has autosaving try disabling that if possible.

It happens in random times at any point..

I already have the ubisoft overlay turned off, not sure I can turn the steam deck one off when in steam ui? I've just tried turning off wifi which made ubisoft connect run in offline mode, still froze.

smintman commented 2 years ago

Checked to see if I can turn off autosave, not sure there is a feature to do that? The game is saving tho, as it does seem to remember where I was sometimes as I'm running about waiting for it to freeze.

Blisto91 commented 2 years ago

Just throwing random stuff at the wall here, don't have a good idea of what the issue could be atm 😁

smintman commented 2 years ago

Just throwing random stuff at the wall here, don't have a good idea of what the issue could be atm grin

I know, but it is worth exploring everything, thanks.

ivyl commented 2 years ago

issues reported by steamdeck users and windows 7 users

Is it Steam Deck only or does it reproduce on desktop too? I've been running the game for over an hour on the desktop now.

So the problem also seems to be present on Windows 7?

MaCroX95 commented 2 years ago

issues reported by steamdeck users and windows 7 users

Is it Steam Deck only or does it reproduce on desktop too? I've been running the game for over an hour on the desktop now.

So the problem also seems to be present on Windows 7?

This issue is also present on desktop for me. I'm using Fedora 36 w Gnome 42.

TheHaf commented 2 years ago

According to the Ubi forums, normal Win7 users have the same issue as we do. I assume their reports refer to normal desktop installations, I hope nobody tries to install Win7 on the Steam Deck. 😉Am 11.07.22, 16:13 schrieb Arkadiusz Hiler @.***>:

issues reported by steamdeck users and windows 7 users

Is it Steam Deck only or does it reproduce on desktop too? I've been running the game for over an hour on the desktop now. So the problem also seems to be present on Windows 7? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

mercifulboss commented 2 years ago

issues reported by steamdeck users and windows 7 users

Is it Steam Deck only or does it reproduce on desktop too? I've been running the game for over an hour on the desktop now. So the problem also seems to be present on Windows 7?

This issue is also present on desktop for me. I'm using Fedora 36 w Gnome 42.

Can confirm. I also have the issue with Nvidia 2060 on arch with kde

mercifulboss commented 2 years ago

Hi. We were unable to reproduce by simply running the game. Do you need to reach a certain point in the story for it to crash?

Also can someone share a full log of the crash? The snippet above doesn't contain anything that would help us pinpoint the issue.

The game will consistently freeze right at the beginning when you exit the tomb and see the soldiers.

Also, it seems to be an issue on NVIDIA systems in particular. With protonGE7.23 you can get past the initial menu and sometimes it will freeze during load screen particularly if you move the character around while its loading.

I reinstalled AC:O to check if it was my system. This was present even on a new install - seems to be caused by ubisoft update.

Edit: here is the windows 7 reports on freezing

https://discussions.ubisoft.com/topic/159932/tu-1-6-0-experiencing-crashes-freezes-when-playing-assassin-s-creed-origins-on-windows-7-post-here/7?page=1&lang=en-US

People also having issues on steam

https://steamcommunity.com/app/582160/discussions/1/3415431214860189324/

The game doesn't crash - it just freezes and even if you leave it for an hour it doesn't change.

smintman commented 2 years ago

issues reported by steamdeck users and windows 7 users

Is it Steam Deck only or does it reproduce on desktop too? I've been running the game for over an hour on the desktop now.

So the problem also seems to be present on Windows 7?

Are you running about or just have it open? I managed to leave the game running for about 30 mins once, and only froze when some soldiers noticed me and decided to fight.. increasing what was happening on the screen.

Yes Windows 7 users appear to have the same issue, what would be common between windows 7 and proton?

MaCroX95 commented 2 years ago

Replying to https://github.com/ValveSoftware/Proton/issues/928#issuecomment-1180509537

It's not a nvidia issue, I have AMD RX 5700XT.

gofman commented 2 years ago

Can anyone who is reproducing the hang in Assassin Creed Origins try that with the build from here: https://www.codeweavers.com/xfer/gofman/builds/ if possible? Password (lock key): testbuild . As far as my debugging goes it might be fixing it but I am not sure, reproducing that too unreliably. Would be great to know if that really fixes it before making a rather quirky fix.

smintman commented 2 years ago

Trying it out right now had an initial free on splash screen when tried via desktop. Rebooted into steam ui and seems to be fairing better been playing for last 20 mins will keep testing and let you know if it reoccurs

smintman commented 2 years ago

Just noticed there’s no sound tho

smintman commented 2 years ago

Played for over hour and no freezing in game. Would sometimes freeze on the “warning:please read splash”.

Still no sound and going back to normal proton there still was no sound. In process of reinstalling origins right not see see if resolves it?

gofman commented 2 years ago

@smintman I am not sure what is "warning:please read splash”?

Regarding no sound, could it be you accidentally muted it in desktop mode as a per app setting in menu? Pulseaudio remembers those settings... "pactl list sink-inputs" while the game is running might show that.

smintman commented 2 years ago

@smintman I am not sure what is "warning:please read splash”?

Regarding no sound, could it be you accidentally muted it in desktop mode as a per app setting in menu? Pulseaudio remembers those settings... "pactl list sink-inputs" while the game is running might show that.

The warning screen that ac origins first shows when it’s booting up.

I think you right about the pulse audio thing how’s best to reset that?

smintman commented 2 years ago

@smintman I am not sure what is "warning:please read splash”?

Regarding no sound, could it be you accidentally muted it in desktop mode as a per app setting in menu? Pulseaudio remembers those settings... "pactl list sink-inputs" while the game is running might show that.

I will continue to try your build tomorrow it was looking promising. What is your fix?

gofman commented 2 years ago

@smintman I am not sure what is "warning:please read splash”? Regarding no sound, could it be you accidentally muted it in desktop mode as a per app setting in menu? Pulseaudio remembers those settings... "pactl list sink-inputs" while the game is running might show that.

The warning screen that ac origins first shows when it’s booting up.

Hmm... I don't see any warnings on start on Deck.

I think you right about the pulse audio thing how’s best to reset that?

You can find the sink index with 'pactl list sink-inputs' (application.name property will be ACOrigins.exe for the correct sink) and then 'pactl set-sink-input-volume 100%'. There also should be possible to delete all the pulseaudio config in the home folder but I am not exactly familiar with configuring this stuff and afraid to advise something bad :)

smintman commented 2 years ago

Replying to https://github.com/ValveSoftware/Proton/issues/928#issuecomment-1181082428

Resolved the audio thanks. Was having issues running it in desktop to make changes, see below.

Here’s where I’m at on desktop mode freezes quite a lot on the warning splash screen. It’s the first screen that comes with with some legal blurb?

On steam ui can get into the game and just played for another 30 mins. So whatever you have changed it’s alot better. Hopefully some others can download your build and give it a go?

gofman commented 2 years ago

@smintman Thanks a lot for testing this. The fix should be now live in Proton Experimental [bleeding edge] branch (available to select in Proton Experimental properties, "Betas" tab): https://github.com/ValveSoftware/wine/commit/872e73ae5c874c58345fe6058a2734da9e156cda

I didn't look at desktop mode warning, that is likely something unrelated to this in-game (or in-menu) freeze issue.

smintman commented 2 years ago

@smintman Thanks a lot for testing this. The fix should be now live in Proton Experimental [bleeding edge] branch (available to select in Proton Experimental properties, "Betas" tab): ValveSoftware/wine@872e73a

I didn't look at desktop mode warning, that is likely something unrelated to this in-game (or in-menu) freeze issue.

Yeah don’t worry about the intial freeze too much. As long as the game works once we get past that. Which it seems it does. Will give the bleeding edge version a go. Thanks for looking into this!

smintman commented 2 years ago

Is there anything we can feedback to the Ubisoft support forum as to why this issue was happening, as I think it was also affecting windows 7 users?

smintman commented 2 years ago

Further update from me, I've left the game running for about 4 hours on Steam UI using proton experimental (bleeding edge) basically getting him on his Camel and riding around the map, so I would say its fixed there.

On Desktop with that proton version the game will get stuck on this screen and get no further. image

Blisto91 commented 2 years ago

@smintman Does it get stuck every time there on desktop or just sometimes?

smintman commented 2 years ago

Seems like every time, at least for me,

Blisto91 commented 2 years ago

Just a quick check. Does this also happen with wined3d?

PROTON_USE_WINED3D=1 %command%
smintman commented 2 years ago

It gets past the splash screen with that command, but of course doesn't look very good.

Strangely moving back to proton 7.0.3 doesn't help, so unless something cached somewhere

Here's a log from when it crashed

steam-17116730227024723968.zip


Blisto91 commented 2 years ago

On the desktop in the steam settings try turning off shader pre cache and see if that makes a difference without wined3d

vahidshirvani commented 2 years ago

@smintman Thanks a lot for testing this. The fix should be now live in Proton Experimental [bleeding edge] branch (available to select in Proton Experimental properties, "Betas" tab): ValveSoftware/wine@872e73a

I didn't look at desktop mode warning, that is likely something unrelated to this in-game (or in-menu) freeze issue.

Want to confirm that your fix indeed works. Thanks a lot.

gofman commented 2 years ago

@smintman

Is there anything we can feedback to the Ubisoft support forum as to why this issue was happening, as I think it was also affecting windows 7 users?

I am not sure if it is the same issue on Win7, I don't have a Win7 machine to run my tests now. If anyone is curious attached is my test case (source code and that code compiled with MSVC for x64/Release, default options). Running that on Win7 and showing the output (or comparing that with Win10) may tell if that is the same issue. test.zip

UPDATE: I actually attached wrong source code, here is the actual one: https://gist.github.com/gofman/3287a953bcab3a5c888a8d494461cb8a

mercifulboss commented 2 years ago

Replying to https://github.com/ValveSoftware/Proton/issues/928#issuecomment-1181853424

thank you, the fix seems to work. not sure what caused it but it seems to work on multiple game launches and playing for 10 mins. however, i discovered that trying to use steam overlay (to get rid of CD key appearing) will freeze the game again.

kakra commented 2 years ago

Many Ubisoft games seem to be unstable with the Steam overlay, so you may want to disable it for those games. Should get rid of the key notification, too.

mercifulboss commented 2 years ago

I understand it is likely better to get rid of steam overlay, but when I do I encounter another issue - steam stops recognizing my controller. This is only fixed by closing the game and then turning on steam overlay. So it leaves me with no choice unfortunately, which is why I was wondering if something can be done about the steam overlay?

kakra commented 2 years ago

Hmm, strange... The controller still works for me even with the overlay disabled. Then again, maybe you're using Steam Input, and that seems to require the Steam overlay enabled for some games (e.g., HZD) for the controller to work. So you could also try disabling Steam Input for this game, most SDL-supported controllers should still work then.