ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
649 stars 75 forks source link

[CS:S] CVar "cl_new_impact_effects" disables (breaks) almost all particles that are supposed to change by this command. #2639

Open MOCOLONI opened 6 years ago

MOCOLONI commented 6 years ago

This is a command I've been using in TF2 for a while, and just recently wanted to enable it in CS:S. However, I noticed that there are no particles being drawn while it's enabled, having the console being flooded with red errors reporting ' Attempted to create unknown particle system type ""! ' Particles like blood impact, HE Grenade explosions, Smoke Grenade and Water bullet impact still show up, however.

It's probably due to an improper or unintended port from TF2's feature.

agrastiOs commented 6 years ago

It probably exists because of the recent CS:S update.

hogsy commented 6 years ago

It's probably due to an improper or unintended port from TF2's feature.

This var was introduced in post-2007 Source Engine games, it will in essence switch impact effects to use Valve's new particle system as opposed to their original hard-coded implementation.

Doesn't work in most games (e.g. Half-Life 2: Episode Two) simply because the effects aren't included and the implementation is incomplete.

The easy solution here is for Valve to either remove the variable in CSS or to just ignore it.