ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
634 stars 74 forks source link

[TF2] Incorrect update_url in mainmenuoverride.res #3217

Open Tiagoquix opened 4 years ago

Tiagoquix commented 4 years ago

In the mainmenuoverride.res file, the update_url parameter points the user to

http://store.steampowered.com/news/?filter=updates&appids=440

but this is incorrect since if you follow that link you will see all news for Team Fortress 2, and not only the updates. The link should be

http://store.steampowered.com/oldnews/?appids=440&appgroupname=Team+Fortress+2&feed=steam_updates

and then the link will be the correct link.

Yetoo1 commented 3 years ago

@Tiagoquix Why did you close this?

Tiagoquix commented 3 years ago

@Tiagoquix Why did you close this?

Just test the links. Apparently, over time, Steam did some changes to the News page and now the link redirects to the correct page.

If you use the current link present in mainmenuoverride.res, it will redirect to the new News page.

The new link I suggested redirects to the old News page.

Since the purpose was to make the link redirect to the new News page, this is not a problem anymore.

Yetoo1 commented 3 years ago

@Tiagoquix Yes, while the link you suggested redirects to old news, the original link still shows all news instead of just updates as stated in the bug report. The original link also doesn't show all smaller updates before November or whenever the new news page was introduced and still shows news posts that are more than updates (albeit any content requires a user to use a filter to see, but there is no filter for just content updates despite the existing content update filter). Yes, I understand that due to the changes in steam there is no way the developers of TF2 are going to change the update string to an older version of steam news and instead try to keep up with the changes of steam, but if one were going by the direct words of the bug report, it's still technically an issue since a more direct page exists. A developer would need to mark as won't fix or delineate that the new news link is supposed to do that functionality but it is not implemented yet if the bug were to be closed.