search

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
649 stars 75 forks source link

[TF2] Vaccinator Resist icon can permanently stay on enemy Spies #3941

Open agrastiOs opened 2 years ago

agrastiOs commented 2 years ago

Occasionally, after a Medic using the Vaccinator Ubercharges a disguised enemy Spy, if that Spy loses his disguise, the Spy will be permanently stuck with the resist icon above their head, even when disguised or invisible, essentially making the class unplayable.

Thanks for reading the report.

jh34ghu43gu commented 2 years ago

Cannot replicate on a LAN server (and a random community one tho they had plugins), although there appears to be a ghost icon that causes any different resistances to appear offset (such as when you use 2 charges at once except I could only see 1). The ghost icon disappears when healed with the same resist type.

SirBlockles commented 8 months ago

To expand on this issue: it isn't tied to Spy's disguise, but rather the fact that the vaccinator resistance icons are only cleared under certain circumstances. Specifically, the icon appears to persist between team changes. Easy (lazy) fix would be to have the vaccinator icons clear themselves every player spawn but obviously clearing them when the player loses the effect is the ideal solution.

The bug can be easily reproduced if the player with the resistance icon changes team at the moment they have the icon over them - for example if teams switch sides on payload, or if a player willingly switches to the other team (or spectate) while healing or being healed by the vaccinator. It doesn't matter if it's the passive resistance or the ubercharge, they both have the same effect.

After some extended experimentation, the icon can be reliably cleared away simply by changing class. A vaccinator medic of the appropriate team applying and removing the resistance can also fix it - the RED and BLU variants of the resistance icons are considered separate icons so if the ghost icons are red, a BLU medic healing will only add blue icons in with the red. Also, simply respawning by e.g. changing loadout, even if you respawn far enough away to detach the healbeam, will not leave the player with a floating resistance icon - it seems to only be associated with changing teams. My basic intuitive guess would be that because the heal target is on a different team, the medigun breaks out of some logic too early since its heal target is invalid (not a teammate) but i can't be too certain.

Screenshot showing the multi-team resistance icons image

...and revealing an enemy Spy (also threw jarate to show it's not just a random bugged particle which also happens sometimes) image

jh34ghu43gu commented 8 months ago

The bug can be easily reproduced if the player with the resistance icon changes team at the moment they have the icon over them - for example if teams switch sides on payload, or if a player willingly switches to the other team (or spectate) while healing or being healed by the vaccinator. It doesn't matter if it's the passive resistance or the ubercharge, they both have the same effect.

This would be a duplicate of #2334 then, OP's description appears to be a different issue.