search

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
646 stars 74 forks source link

[TF2] dragon's fury fireball particle is not fully representative of the projectile #4028

Open SirBlockles opened 2 years ago

SirBlockles commented 2 years ago

there are several instances where the visual fire particle of the dragon's fury fireballs no longer matches up with its projectile. the most common instance of this happening in-game is when it is reflected by an enemy pyro - the projectile is sent back, but the particle continues moving forward through the enemy pyro. the same happens when the projectile is destroyed by a short circuit or simply collides with a wonky map prop.

so far, the only circumstance in the game i have seen change the particle is increasing tf_fireball_speed, which makes the particle extend farther or shorter depending on how you change it. note that this, too, is not representative of the actual projectile (as can be seen by enabling tf_fireball_draw_debug_radius) unless the tf_fireball_distance is increased/decreased by the same factor (eg. 2x)

with this on top of #3897, the entire particle/projectile is probably in need of an internal overhaul.

AzureWoof commented 2 years ago

iirc the projectile also collides with syringe gun syringes for some reason, (while the particle itself still exists, it'll do no damage after colliding with a syringe) but I'm unsure if that was already addressed in a previous patch or not.

SirBlockles commented 2 years ago

iirc the projectile also collides with syringe gun syringes for some reason, (while the particle itself still exists, it'll do no damage after colliding with a syringe) but I'm unsure if that was already addressed in a previous patch or not.

it was reported and marked as fixed in #3542, but that's not something i've tested directly

VirtualSoda commented 2 years ago

The bug where the DF collides with other projectiles has been fixed in the November 15th, 2021 update.

It is true though that the particle doesn't really represent the actual projectile. Which is a bit of an issue. The size of the particle represents the entire hitbox of the fireball (the particle itself is too big compared to the actual hitbox) But now that you need to hit the center of that fireball hitbox to actually get the bonus damage, it is difficult to get a sense of where you exactly need to hit enemies in order to get the bonus damage.

I suggest making the fireball particle size smaller to represent the center of the entire hitbox. Which this mod has already done (with some other visual changes to the particle): https://github.com/agrastiOs/Ultimate-TF2-Visual-Fix-Pack

SirBlockles commented 2 years ago

I suggest making the fireball particle size smaller to represent the center of the entire hitbox.

that treads matter-of-opinion territory, because i personally prefer the particle representing the entire hitbox of the projectile, rather than just the center. it would be quite annoying to have the fireball visually miss you but still get ignited because you weren't hit with the sweetspot but still the outer part of it.

and yeah, the particle was originally designed when the radius was 30 on release, which has now been reduced to 22.5. while i personally think the radius should increase just a tiny bit (like, to 24 or something) it is pretty annoying to have the fireball visually look like it SHOULD have connected but it doesn't simply because the particle was designed for a larger projectile.

VirtualSoda commented 2 years ago

that treads matter-of-opinion territory, because i personally prefer the particle representing the entire hitbox of the projectile, rather than just the center. it would be quite annoying to have the fireball visually miss you but still get ignited because you weren't hit with the sweetspot but still the outer part of it.

and yeah, the particle was originally designed when the radius was 30 on release, which has now been reduced to 22.5. while i personally think the radius should increase just a tiny bit (like, to 24 or something) it is pretty annoying to have the fireball visually look like it SHOULD have connected but it doesn't simply because the particle was designed for a larger projectile.

I suppose you're right. I definitely agree that the least that should happen is to update the particle size to be apropos for the actual hitbox size