ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
647 stars 75 forks source link

[TF2] Typo in item schema: "equip_region" instead of "equip_regions", allowing hats to incorrectly not conflict with other items #4102

Open sapphonie opened 2 years ago

sapphonie commented 2 years ago

This effects 11 hats:

You can search for: "equip_region"\n\t\t\t{

For example, the Bone-Cut Belt:

            "equip_region"
            {
                "left_shoulder"     "1"
                "shirt"     "1"
            }

should be

            "equip_regions"
            {
                "left_shoulder"     "1"
                "shirt"     "1"
            }

Thank you to @nosoop for the info.

jh34ghu43gu commented 2 years ago

This was already fixed on October 25, 2018 but was reverted in the subsequent patch on October 30, 2018 presumably due to backlash.

sapphonie commented 2 years ago

Confirmed to not be fixed as of the update a few days ago

Ashetf2 commented 1 year ago

Undocumented change on the January 5, 2023 patch:

Fixed a typo that prevented the equip_regions of several cosmetic items from working properly

All items listed had their equip regions fixed

jh34ghu43gu commented 1 year ago

@Ashetf2 that got undone around the 9th but there hasn't been an update since then to add it as another undocumented change.

Considering it's now been undone at least twice, seems like this is an intentional feature?

Edit: January 9th for clarity.

Ashetf2 commented 1 year ago

@jh34ghu43gu the fix hasn't been undone wtym?

image

jh34ghu43gu commented 1 year ago

@Ashetf2 The current schema the GC uses is http://media.steampowered.com/apps/440/scripts/items/items_game.a9a36739afb15ffd5e1b1979f8e58589f49aee43.txt -> https://imgur.com/QFO3rS3

which you can verify using the api (add your dev key to the end) https://api.steampowered.com/IEconItems_440/GetSchemaURL/v1/?key=

The local schema is not updated for players but the GC one is the one that matters and you can currently equip these items without conflicts. I think swood and one other in the wiki IRC said they become unequipped for him when he relaunched the game but I couldn't replicate it, IIRC they were stacking the same cosmetic twice which I don't have access to try with.

Ashetf2 commented 1 year ago

Nvm it was reverted in today's patch

Tiagoquix commented 5 months ago

I think it's still wrong for this item:

image

The others seem to have been fixed.

jh34ghu43gu commented 5 months ago

The others seem to have been fixed.

No? If you are using the provided regex search you need to add a space between the " and \n

Tiagoquix commented 5 months ago

@jh34ghu43gu Indeed. Thanks for the clarification. 14 matches found here.