Closed rowedahelicon closed 1 year ago
fixed with this sourcemod plugin, fixable by bumping the ParticleEffectNames stringtable size to... something bigger, properly fixable by clearing that strtable every map load
I am having the exact same issue constantly, It didnt used to happen before the latest patch came into effect
I am having the exact same issue constantly, It didnt used to happen before the latest patch came into effect
I made a small edit to my post above, I believe that the summer crate is most likely what set this over the limit with the addition of new unusual effects.
Ooooh dear, that makes so much more sense, I really hope it gets sorted out, I really hope valve is actively looking into this
The problem here isn't that the table isn't cleared. It definitely is cleared every changelevel in SV_CreateNetworkStringTables.
The real problem is that the particle manager dictionary is not cleared on changelevel, which then appends some of the particles from the maps that have their own particle manifests into it as a bunch of these maps with particle manifests have force precache applied to some particle files. The particle manager dictionary is then used to re-populate the particle string tables, which is why you think it isn't being cleared.
It looks like we are also running reeeeeally close to the particle limit as well, especially on those halloween maps, so I have also raised the table to 8192 for the next update.
Thanks for the report!
The problem here isn't that the table isn't cleared. It definitely is cleared every changelevel in SV_CreateNetworkStringTables.
The real problem is that the particle manager dictionary is not cleared on changelevel, which then appends some of the particles from the maps that have their own particle manifests into it as a bunch of these maps with particle manifests have force precache applied to some particle files. The particle manager dictionary is then used to re-populate the particle string tables, which is why you think it isn't being cleared.
It looks like we are also running reeeeeally close to the particle limit as well, especially on those halloween maps, so I have also raised the table to 8096 for the next update.
Thanks for the report!
Excellent news, thank you! Understandable too, I did originally try poking at the particle dictionary as per the method used in the CS:GO plugin, though I was unable to replicate the fix without constant server crashes. I was even surprised to see eventually that simply increasing the size of the table was a sufficient fix as the tables are more or less representations of the data.
Regardless, I am very thankful to see this being addressed! <3
Hello, per "Fixed precached particles not being deleted across map changes" in the 2022-09-26 Team Fortress 2 update, please retest this issue.
Hello, per "Fixed precached particles not being deleted across map changes" in the 2022-09-26 Team Fortress 2 update, please retest this issue.
I can confirm, having gone through my list of around 20 Halloween maps, that the problem has indeed been solved. The list no long flows over ~4096 particles after a series of map changes.
Fix works
(played several maps in the same server to see if the "red X spam" occours, it doesn't anymore) +see previous comment
issue can be closed
Similar to, if not exactly the same problem described here https://forums.alliedmods.net/showthread.php?t=322106.
As a server moves from map to map, those using atypical particles (such as Halloween maps) have begun precaching them to the particle string table and no longer is removing them on map end. This eventually results in a full particle string table, which then removes many important particles from cache, such as weapon muzzle flashes. This is not a TF2 exclusive issue, it has been known to happen in CS:GO too.
https://www.diffchecker.com/9r0o85kd The is a comparison of the "ParticleEffectNames" string table, the left being after a server restart, the right being around ~12 hours later.
Easiest way to replicate it is to jump around Halloween maps, most of the stock event maps contributed a decent number of stuck particles per map.
9/4/2022 Edit: I want to emphasize for the sake of importance, this issue most likely has been occurring for a while and was exacerbated by the recent update which added more Unusual effects. This will be a problem for many servers, including Valve servers, come the upcoming Halloween event.