ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
647 stars 75 forks source link

[TF2] Gargoyles can spawn outside of playable area on Helltower. #4456

Open hobophobe opened 2 years ago

hobophobe commented 2 years ago

There is a spot for gargoyles to spawn in the side of the cliff below the clocktower/portal where players run to while the bridge is open. It's not reachable, even if you try to dive into it or otherwise get to the spot. 20221026200130_1

Screenshot shows the gargoyle sticking out of the cliff from the viewpoint of the bridge. It is the green thing to the left of the pink crosshair.

Chickenman456 commented 2 years ago

This is moreso a gameplay issue, not art

kisak-valve commented 2 years ago

For clarity, I read this as a static map design issue instead of an engine issue, which roughly approximates to the art label.

Chickenman456 commented 2 years ago

My bad, sorry if I sounded rude

The gargoyles are collectibles that move around the pre-determined areas in the map.

Ashetf2 commented 2 years ago

This is weird. Community maps use ´tf_halloween_gift_spawn_location´ to locate where the Soul Gargoyles spawn. For example, in Ghoulpit: image However, Helltower doesn't have that entity in any spot, so I guess it's hardcoded? image

Doclic commented 2 years ago

Helltower doesn't have that entity in any spot, so I guess it's hardcoded?

I did a few checks, and it is. Mann Manor, Eyeaduct, Ghost Fort, and Helltower all have their Soul Gargoyle locations hardcoded in the code. Helltower has a spawn point near 10225 7462 -367 and another near 10209 7768 -367 (you can use the setpos command to go to these locations if the server has cheats enabled)

While you could fix this by just removing these 2 problem locations from the code, it would be way better to just scrap these hardcoded locations entirely, and add them to the map files.

jh34ghu43gu commented 2 years ago

I guess it's hardcoded?

Man I went digging for these locations to make maps for the wiki and it was awful if I remember right (did this in December last year). The conclusion I came to was some maps use the entities (which makes locations findable and even spawn outside of the halloween event in listen servers) and other maps rely on the hard coded values, and then some maps use a post-load list directly from the GC that we can't access. I believe I sourced that last bit of information from the alliedmodders community forums. (I also requested these locations last year via email, any chance on a followup :))

That said, having helltower's gargoyle location(s) change this year makes me think every location is handled by the GC's list, that location almost looks like it might be a mirror on 2 axis for the spot on the hill so maybe there was some copy paste error and some negative signs thrown in the mix?

Edit: forgot I left a comment about my findings on the wiki page too: link

Edit2: If my previous comments are accurate then this is possibly a lag related issue since the client is handling the rendering. Similar to how a large lag spike may render other players invisible, but perhaps only occurring if the lag spike occurs when the server sends the next gargoyle position? I've only seen this posted one other time on reddit (might be the same person) so it seems rare as I would assume this being a legit location would make it very common (and thus reposted to death). @hobophobe would you happen to remember if you had lag spikes (or symptoms of one such as aforementioned invis players) during this match?

Doclic commented 2 years ago

That said, having helltower's gargoyle location(s) change this year makes me think every location is handled by the GC's list

The locations didn't change this year, you can play with old versions of the game (you can download old depot manifests with SteamDB), and the Gargoyles will still spawn here. You can even go on a listen server on the current TF2 version and set host_timescale to 30 to speed up time, and you'll eventually see a Gargoyle spawn in this spot.