ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
647 stars 75 forks source link

[TF2] Recently-changed multi-region cosmetics can be equipped together but unequip once game is restarted #4678

Open JoriKos opened 1 year ago

JoriKos commented 1 year ago

The 5 January 2023 update fixed the equip regions for some cosmetic, however, they can still be equipped together with clashing cosmetics through the backpack menu. image

However, once the game is restarted it returns to this. image

gabrielwoj commented 1 year ago

Here's an example with an item that conflicts with the other 2 cosmetics items.

The Beep Man has a "whole_head" and "shirt" equip_regions. It conflicts with the Antarctic Researcher as it also uses "shirt", and it conflicts with the Wiki Cap as it uses "hat" (which is shared with the "whole_head" region).

Despite the conflicting equip_regions, the game lets me equip the Beep Man without any issue, it also does not require using the "quickswitch" method. image Once restarting the game, it unequips only the Beep Man: image Although, the game lets me use the conflicting item at anytime, as it will only unequip once I close the game.

jh34ghu43gu commented 1 year ago

This change was reverted (thank you whoever did that) when the schema updated for the end of the smissmas event. http://media.steampowered.com/apps/440/scripts/items/items_game.a9a36739afb15ffd5e1b1979f8e58589f49aee43.txt <- current schema at time of posting, note equip_region instead of equip_regions on the affected items (such as the chicken kiev or beep man). The unequip bug might have been because the local time and server time disagreed on schemas but this no longer appears to be the case, at least for me.

Edit: I am GMT-6, I did not have multiple aviants but I tried an aviant with a hat and they did not unequip

JoriKos commented 1 year ago

From my testing right now, the Avian Amante example still works.

As for the timezones thing, Gabriel lives in GMT -3 and I live in GMT +1 and we both experienced the bug at the same time (if this information is of any help).

gabrielwoj commented 1 year ago

Hi. I can also confirm that the Beep Man example still works for me.

I also recorded a video showing in action. I also realized that, if I equip the Beep Man with just a hat, the item won't unequip itself upon restarting, only with a shirt item.

I don't have a whole_head equip_region item to test with it, only the Beep Man (which has "whole_head") together cosmetics that has the "hat" region (where "hats" conflict with "whole_head" items).

https://user-images.githubusercontent.com/13741779/211335565-e27a26b8-a7ff-4ea6-831e-b2f2925796ab.mp4

Tiagoquix commented 3 months ago

Is this still relevant as of 2024?

JoriKos commented 3 months ago

Yes, the fix they made for it was reverted