ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
633 stars 74 forks source link

Team Fortress 2 "sv_pure 1" whitelist deregulation #4689

Open AtomicTEM opened 1 year ago

AtomicTEM commented 1 year ago

The current sv_pure whitelist for Team Fortress 2 is far too restrictive, as the whitelisting of custom viewmodel animation (which are separate of weapons models) and certain models and materials content customization on Casual servers if made available to customize on the client side would have no effect on gameplay, as in giving an advantage to the user of said customized content.

For example the restriction of all .pcf (particles) files is unecessary. The only .pcf files that could be edited to give an advantage to the user would be teleport_status.pcf and teleported_fx.pcf

There needs to be a revision of the casual servers sv_pure 1 whitelist to allow for further clientside custom content.

AtomicTEM commented 1 year ago

P.S the current sv_pure 1 whitelist causes issues in the testing of custom content that can be submitted to the steam workshop, such as loading of assets on itemtest.

condor00fr commented 1 year ago

Sv_pure is annoying and generaly hated by the community due to the near inability to use custom content, yet not much talked about due to much bigger issues. The only things that work are custom huds and first person animations when loaded with the Item Test map. I had already made an Issue about it last year.

condor00fr commented 1 year ago

Also, from what I remember, Sv_pure was instored in awnser to some popular wall hacks who where simply uptated to bypass the new "security" feature, In otherwords it failed at what it was supposed to do in every aspects

Thespikedballofdoom commented 1 year ago

Lots of crashes on second load on valve servers when mods and sv pure mix. Sound sprays should totally be whitelisted too even assuming sv_allowdownload 0 is kept for caual

FrozenDragon0 commented 1 year ago

sv_pure really needs to be reworked, it's especially fucking annoying when your game just straight up crashes over custom content being blocked occasionally.

Whurrhurr commented 1 month ago

i know this issue is old, but i'm going to throw my 2 cents into what should be whitelisted (in casual/bootcamp/mannup, anyway)

Sounds

what should be whitelisted: Everything that isn't footstep sounds and spy cloak/uncloak sounds. self explanatory, nothing else really gives you as big of an advantage over other players as those sounds do.

Textures/Models

what should be whitelisted: Class Icons, Class Portraits, Viewmodel arms/animations, Playermodels, Cosmetics, Engineer Buildings, and Weapons. originally i was going to say "just whitelist everything lol" but this is probably the next best thing (and the one that's far more likely to happen) class icons/portraits because they're just user taste/flavor and don't impact gameplay, same with viewmodel hands/arms/custom viewmodel animations, purely user flavor and don't impact gameplay. playermodels and cosmetics because they're also user flavor/taste, and while they can impact gameplay, it's better than having people crash because they joined an sv_pure server that had playermodel mods blacklisted. cosmetics also don't really affect gameplay, so if someone wants to run a mod that hides cosmetics, they can do that. if someone wants to run a weapon mod that replaces the model of a weapon, they can do that as well. ditto for engineer buildings (even though there's not really that many mods for those out there)

so there is my list, and my justifications for why those things should be whitelisted. i know it probably won't happen, but let people dream at least.

HueyCan commented 1 month ago

Really the only other things that shouldn't be whitelisted besides certain sounds and particles would be map textures and most map props since those can be edited in a way to get "wall hacks". A few map props like the control point and intel briefcase should be fine to whitelist though. It could be argued that playermodels shouldn't be whitelisted but besides editing either models or textures for them to be more noticeable, the gameplay impact isn't large especially in a casual setting where winning isn't hugely desired for most players.