[TF2] Add a rate limit check for in-game party text chat

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source

643 stars 74 forks source link

[TF2] Add a rate limit check for in-game party text chat #4843

Open impale1 opened 1 year ago

impale1 commented 1 year ago

Spam in party chat can slow down low-end PCs
Some streamers encourage their viewers to play along with them, and spammers can ruin their experience.
The spammer could be your friend, and you don't want to kick him off the party just because of that.

https://docs.mastercomfig.com/page/customization/modules/#party-join-mode

The Friends Only restriction for parties can be bypassed, which means anyone can join your party if they have your Steam ID. Leaving your party open can result in anyone to join your party and spam party chat, causing lag, sound spam and other disruptions.

RicochetYT commented 1 year ago

This could also probably hinder cheats that use the party chat for communication with other cheats if implemented properly.

jh34ghu43gu commented 1 year ago

Spam in party chat can slow down low-end PCs

It will crash your game if you don't have the party chat window open on the main menu. Low-end or not. (OS dependent possibly)

lnx00 commented 1 year ago

Instead of applying a rate-limit, it would be better to fix the source of the lag instead. The lag seems to be caused by the message popup that appears when a new message arrives. It doesn't lag when the party chat is open while a message arrives since this prevents the message popup.

Displaying a simple text popup shouldn't have a noticeable impact on the game's performance. There's probably something unintended happening behind the scenes.

StefanCrime commented 1 year ago

Spam in party chat can slow down low-end PCs

Some streamers encourage their viewers to play along with them, and spammers can ruin their experience.

The spammer could be your friend, and you don't want to kick him off the party just because of that.

https://docs.mastercomfig.com/page/customization/modules/#party-join-mode

The Friends Only restriction for parties can be bypassed, which means anyone can join your party if they have your Steam ID. Leaving your party open can result in anyone to join your party and spam party chat, causing lag, sound spam and other disruptions.

Hello! Sorry, I'm new here. How can we use: party_mode=request in-game? Thanks!

mtxfellen commented 1 year ago

@StefanCrime tf_party_join_request_mode 1 is the console command you're looking for; the above documentation only applies to users of that specific config.