search

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
647 stars 75 forks source link

Can't use loadout/inventory #5707

Open thehuyxl opened 6 months ago

thehuyxl commented 6 months ago

image

This is how my loadout looks like, i can't use anything or change my loadout, maybe this is caused by my hud?

leadscales commented 6 months ago

this update busted a ton of custom huds, including almost all of mine and many others as well. probably just uninstall the hud for now. seems they patched a perfectly good method of aligning the charinfopanel with the subpanel. can't have anything nice :/

a bandaid fix for now for most custom huds is to go to <hud>/resource/ui/charfinfopanel.res and set character_info -> settitlebarvisible to 1. this, of course, will break the positioning of almost everything, but you can, at least, still use it i guess.

leadscales commented 6 months ago

image

it seems the ypos of the sheet is completely randomized every time the menu gets reloaded? the only thing preventing it doing that is having the title bar enabled, but it did NOT do this in 32 bit tf2. you can adapt to this, but it will ALWAYS be a few pixels off which will be very jarring for certain styles of custom huds.

a really nice solution would be a way just to set the sheet position in the res files manually.

thehuyxl commented 6 months ago

this update busted a ton of custom huds, including almost all of mine and many others as well. probably just uninstall the hud for now. seems they patched a perfectly good method of aligning the charinfopanel with the subpanel. can't have anything nice :/

a bandaid fix for now for most custom huds is to go to <hud>/resource/ui/charfinfopanel.res and set character_info -> settitlebarvisible to 1. this, of course, will break the positioning of almost everything, but you can, at least, still use it i guess.

Thank for your help, it's work! I can use items right now, just a little bit issue that the letters overlap each other but i think it's fine. Thank you so muck!

leadscales commented 6 months ago

some more developments:

the offset seems to be caused by the title bar itself (alongside its own margins i suppose), which always offsets it by 36 pixels, regardless of the resolution, aspect ratio, anything; it completely ignores vgui's scaling. image this would be very easy to work around if you could move things by pixels, instead of vgui units, but you cannot.

i would post part of the source code from the leak that's specifically causing this part of the issue, but i doubt that's welcome here.

setting the title bar's visibility to 0 obviously prevents it from rendering in the first place, stopping this from ever happening... but it appears we cannot do this anymore without the entire sheet changing its ypos to a seemingly random number.

i tried using borders to inset the entire panel exactly 36px, but that also appears to inset the entire gameui panel 36 pixels alongside it. i am not sure if this is intended behavior or not.

some solutions i propose:

EDIT: FIX FOR HUD DEVELOPERS this will make it so the sheet is always at the top of the screen, so you can easily reposition everything from there. in the clientscheme, set BaseSettings -> Frame.ClientInsetY to 0, and in the charinfopanel file, set character_info -> titletextinsety to -30. restart tf2, and reposition everything else from there.