ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
634 stars 74 forks source link

Two vote kicks #6082

Open FixTF2 opened 2 months ago

FixTF2 commented 2 months ago

20240613144059_1

20240612183942_1

As you can see in one of the screenshot there's two vote kicks at the same time. The other screenshot has the vote kick window off to the right. What happened was the first vote kick ended, before the other one. That's why it's just out there. I forgot mention this before, I could vote for both vote kicks.

JoriKos commented 2 months ago

You should separate these two issues, as these problems are unrelated

FixTF2 commented 2 months ago

done

jh34ghu43gu commented 2 months ago

This feels like a custom hud issue?

FixTF2 commented 2 months ago

So you don't recognize the stock default hud?

AzureWoof commented 2 months ago

I've seen this happen before. This might have something to do with both teams starting a votekick immediately before teams are swapped at the start of a new round. One of the previous patches changed the votekick system to allow both teams to have their own votes active at once, so perhaps it's erroneously rendering both active votekicks from each team.

Top image is from right after a team swap, and the bottom image is right after the start of a new round, where I'm guessing the teams were also just recently swapped.

jh34ghu43gu commented 2 months ago

So you don't recognize the stock default hud?

I did not recall the vaccinator charges overlaying the resistance type. I use stock hud and do not have such an overlap so I assumed a custom hud.

coredesu commented 2 months ago

This feels like intentional but not quite. The caller is able to call a vote if the caller is being balanced to the other team.

jh34ghu43gu commented 2 months ago

This feels like intentional but not quite. The caller is able to call a vote if the caller is being balanced to the other team.

Pretty sure the issue is that when the 1st vote expires the 2nd vote does not collapse to the left side and stays floating in the middle.

FixTF2 commented 2 months ago

So you don't recognize the stock default hud?

I did not recall the vaccinator charges overlaying the resistance type. I use stock hud and do not have such an overlap so I assumed a custom hud.

I don't see what you are talking about, but sounds like a another bug

FixTF2 commented 2 months ago

This might have something to do with both teams starting a votekick immediately before teams are swapped at the start of a new round.

I don't think the second vote kick was from the other team because of a detail I forgot to mention, I could vote for both vote kicks.

Top image is from right after a team swap, and the bottom image is right after the start of a new round, where I'm guessing the teams were also just recently swapped.

If I'm remembering correctly, the one on hardwood, (I'm medic) is the start of the game first round. The second one I joined in the middle of the match some time after round one if I'm remembering correctly.

FixTF2 commented 2 months ago

This feels like intentional but not quite. The caller is able to call a vote if the caller is being balanced to the other team.

Pretty sure the issue is that when the 1st vote expires the 2nd vote does not collapse to the left side and stays floating in the middle.

No the vote was active, I forgot to mention, I could vote for both vote kicks.

JoriKos commented 2 months ago

I don't see what you are talking about, but sounds like a another bug

The first ÜberCharge meter is on top of the bullet resistance icon.

FixTF2 commented 2 months ago

The first ÜberCharge meter is on top of the bullet resistance icon.

oh I see now, yea that's got to be another bug, mind if I use your screen shot to make another bug report on this?

JoriKos commented 2 months ago

The first ÜberCharge meter is on top of the bullet resistance icon.

oh I see now, yea that's got to be another bug, mind if I use your screen shot to make another bug report on this?

It's your screenshot.

NULLYUKI commented 2 months ago

While I was trying to research for some more information about this issue, I came across a video that was uploaded to YouTube where you can see the exact same issue happen during a casual match where bots began raiding the lobby. Here is the video: https://youtu.be/SfNAxMrGwEw?feature=shared

NULLYUKI commented 2 months ago

I've seen this happen before. This might have something to do with both teams starting a votekick immediately before teams are swapped at the start of a new round. One of the previous patches changed the votekick system to allow both teams to have their own votes active at once, so perhaps it's erroneously rendering both active votekicks from each team.

Top image is from right after a team swap, and the bottom image is right after the start of a new round, where I'm guessing the teams were also just recently swapped.

Here is the exact patch with the patch notes that updated the votekick system.

139819

Updated vote system

  • Both teams can have a kick vote running at the same time
  • Can have a global vote running at the same time as a kick vote
  • Fixed sometimes not being able to vote on maps at the end of the round