ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
632 stars 73 forks source link

[TF2] Remove unused cvar tf_server_identity_disable_quickplay for deprecated quickplay system #6088

Open KaelaSavia opened 1 month ago

KaelaSavia commented 1 month ago

This cvar servers no purpose now that quickplay has been removed for years.

Commenting it out should be pretty fast

Edit:

Much better alternative, set it to 1 by default as deprecated quickplay system functionality is currently being used maliciously to put servers into custom matchmaking lists without their consent.

As this cvar is set to 0 by default there's no way to stop it and most of server operators don't know about this occuring.

Edit 2:

I have confirmed this won't affect current MvM bootcamp system, as this is handled by seperate non quickplay system and has seperate cvar 'tf_mm_servermode 1'

mastercoms commented 1 month ago

How is it malicious for players to be connecting to servers on the public server list? And any custom server list could just ignore any tags, so there's not much point to remove a way for community servers to easily mark themselves with a standard way to "opt-out" of any custom server list.

KaelaSavia commented 1 month ago

The way your list is setup is malicious in itself and servers should be opt-out by default and not require to use some deprecated convar from quickplay system to avoid it.

Although that would be off-topic subject, but I'd rather not be put on list of servers ran by someone whos sharing around stolen TF2 code from Valve perforce server which probably helped bot hosters have easier time messing with casual.

Account you are sharing leaked source code on in question

Niterux commented 1 month ago

failtroll.

coredesu commented 1 month ago

Hello. The command may look like it doesnt have much of use anymore, but MvM Boot Camp uses Modern matchmaking version of Quickplay, and is used to disable MvM Boot Camp matchmaking for a community gameserver. Ur options to remove urself from the community maintained version of quickplay is explained in the FAQ section of the site.

KaelaSavia commented 1 month ago

Hello. The command may look like it doesnt have much of use anymore, but MvM Boot Camp uses Modern matchmaking version of Quickplay, and is used to disable MvM Boot Camp matchmaking for a community gameserver. Ur options to remove urself from the community maintained version of quickplay is explained in the FAQ section of the site.

I checked website faq and it's even worse than i thought.

You get put into community made quickplay without consent and get complaints that you're violating community quickplays rules despite being put there without consent.

It's literally attempt to bully people into following your rules or you get put onto punishment/bad servers list despite not giving consent to be part of your quickplay system.

Either make that opt-in or stop hijacking Valve quickplay system and trying to enforce rules on servers you don't own nor have rights to own/manage.

Malicious quickplay bootlegs shouldn't have rights to harass people for hosting servers the way they don't like them. It's just powertripping pretending to be Valve and making up playhouse rules.

This conversation was too off-topic but netherless its good argument for cvar being set to 1 by default.

coredesu commented 1 month ago

Replying to https://github.com/ValveSoftware/Source-1-Games/issues/6088#issuecomment-2172045762

This conversation doesnt make much sense, Valves version of Quickplay is limited to MvM Boot Camp and nothing is being hijacked. If u care that much about ur server, ask teamwork.tf, battlemetrics, tsarvar, gamemonitoring to get rid of ur server.

treacherousfiend commented 1 month ago

You get put into community made quickplay without consent and get complaints that you're violating community quickplays rules despite being put there without consent.

It's literally attempt to bully people into following your rules or you get put onto punishment/bad servers list despite not giving consent to be part of your quickplay system.

Either make that opt-in or stop hijacking Valve quickplay system and trying to enforce rules on servers you don't own nor have rights to own/manage.

I don't understand, what punishment or bad servers list do you think is happening? its a community quickplay replacement, it just isn't going to queue people who use that system into those servers. The server host probably won't even know that it ever happened because, well, no one using this quickplay service would get put in that server. If anything, obeying this cvar is a show of good faith, rather than just scraping the master server list and adding every single server.

As far as I understand its literally the exact same thing that Valve was doing prior to Meet Your Match, if your servers didn't follow the rules that they laid out, it wouldn't queue people into it, and that was the end of it.

I do think setting the default of the cvar to 1 probably is the best option though.

Although that would be off-topic subject, but I'd rather not be put on list of servers ran by someone whos sharing around stolen TF2 code from Valve perforce server which probably helped bot hosters have easier time messing with casual.

If you'll forgive me, to me it seems like the issue here isn't the cvar but a personal issue unrelated to the game? For full disclosure, I've committed to mastercomfig and to that aforementioned repository, but I'm just trying to understand your issue. Additionally, the makers of the bot software have their own ways of getting these repos its been on the internet for years and will continue to be, also their software is older than that github repo is as far as I know, and its far from the only github repository hosting it.

gaelcoral commented 1 month ago

The command may look like it doesnt have much of use anymore, but MvM Boot Camp uses Modern matchmaking version of Quickplay, and is used to disable MvM Boot Camp matchmaking for a community gameserver.

That would be the command tf_mm_servermode 0

KaelaSavia commented 1 month ago

The command may look like it doesnt have much of use anymore, but MvM Boot Camp uses Modern matchmaking version of Quickplay, and is used to disable MvM Boot Camp matchmaking for a community gameserver.

That would be the command tf_mm_servermode 0

Added information about it to OP