search

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
635 stars 74 forks source link

[TF2] Enable burning death animations #6236

Open JoriKos opened 1 month ago

JoriKos commented 1 month ago

Outside of the Pyro (who can't die of Afterburn except for the Gas Passer, which is very rare anyway), each class has a burning death animation (similar to headshots and backstabs). I think it would be pretty neat if these animations got implemented, it seems to be as simple as uncommenting line 12744-12747 in tf_player_shared.cpp.

At the very least, I think it could be a ConVar to enable them (possibly off by default to keep current behaviour)

condor00fr commented 1 month ago

There was actually a death animation planned for Pyro that leaked. So why not?

ethanholt1 commented 1 month ago

Seems like a good idea, but I'm concerned that some players may interpret the burning to death animation as the character still being alive (they're standing up and moving) and mistakenly shoot at them.

JoriKos commented 1 month ago

That is a valid concern. I think it's a matter of getting used to it, but I would prefer these animations to be toggled through the use of a ConVar (off by default).

condor00fr commented 1 month ago

Personnaly I think they would have made more sense as deaths for crit flares instead. After all death animations only trigger for specific actions that requires skill such as getting a backstab of a headshot.

Rewarding good flare users with theses would most likely reduce the chances of a wrong interpretation. (But not nullify it.)

JoriKos commented 1 month ago

Personnaly I think they would have made more sense as deaths for crit flares instead.

That, or any crit fire death (Backburner, Phlog, etc.) as they are also crit deaths like the backstab/headshot.

actions that requires skill such as getting a backstab

My skill of having low-quality internet :^)

ethanholt1 commented 1 month ago

they would have made more sense as deaths for crit flares

This accurately rewards the Pyro for pulling off a skillful flamethrower + flare combo, and ensures that the animation won't go off constantly. But this still doesn't help with minimizing people interpreting the animation as an alive player. Maybe a cvar set to on by default (that way people who are having issues with it can turn it off) or a new animation where the class falls to the floor as opposed to standing up.

On Wed, Aug 14, 2024 at 1:39 PM Pygargue00fr @.***> wrote:

Personnaly I think they would have made more sense as deaths for crit flares instead. After all death animations only trigger for specific actions that requires skill such as getting a backstab of a headshot.

Rewarding good flare users with theses would most likely reduce the chances of a wrong interpretation. (But not nullify it.)

— Reply to this email directly, view it on GitHub https://github.com/ValveSoftware/Source-1-Games/issues/6236#issuecomment-2289429000, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6R3XENXCONVUMKD54QKK3TZROI3PAVCNFSM6AAAAABL4OIE6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGQZDSMBQGA . You are receiving this because you commented.Message ID: @.***>

--