ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
660 stars 76 forks source link

[HL2] GorDIN font has incomplete Cyrillic support #6548

Open VladWinner opened 2 weeks ago

VladWinner commented 2 weeks ago

Issue

UI and Options: Replaced instances of system fonts like Verdana throughout the UI with a new font, GorDIN.

The new font is missing several Cyrillic letters, which leads to a partial transition to the fallback font. This makes the text display worse in Russian localization. hl2

Affected letters/glyphs: Ёё, Ыы, Ээ

In-game examples

image 2024-11-16_11-45-08_hl2 2024-11-16_11-45-28_hl2 2024-11-16_11-45-55_hl2 2024-11-16_11-46-40_hl2

Font preview

Windows Font Viewer

image Sample text: Съешь ещё этих мягких французских булок, да выпей чаю

FontLab:

image Sample text:

А Б В Г Д Е Ё Ж З И Й К Л М Н О П Р С Т У Ф Х Ц Ч Ш Щ Ъ Ы Ь Э Ю Я
а б в г д е ё ж з и й к л м н о п р с т у ф х ц ч ш щ ъ ы ь э ю я

Please also keep in mind that the letters "Ёё" in the current version of GorDIN font are composed as adding U+0308 "◌̈" diacritics to the existing letters "Ее", which is a bad solution and is also not supported by Source engine, unlike the font viewers above.

Solution

When creating a custom font, it is highly recommended that the team considers researching other good-looking Cyrillic fonts, such as DIN 2014. P.S. You can find several problems with the lines and proportions of Cyrillic letters if you directly compare the current HL2 font with DIN 2014: ezgif com-optimize (3)

Evisneffo commented 2 weeks ago

Issue with the new GorDIN font: the font currently supports only Ukrainian Cyrillic letters (ґ, є, і, ї), but key characters from the Russian alphabet (ё, э, ы) are missing. Since Russian is the only officially supported Cyrillic language in the game, this makes text in the Russian localization appear incorrect. Please consider adding the missing characters to fully support the Russian localization.

UPD: I've noticed that the letter Ъ (hard sign), which is part of the Russian alphabet but not the Ukrainian one, is present in the font.

9mmarreimu commented 2 weeks ago

Not only does Russian have an impact, Simplified Chinese also has an impact! Some of the text is weird, it feels a bit like Japanese 0001 Screenshot_2024_1119_032630

Evisneffo commented 2 weeks ago

Not only does Russian have an impact, Simplified Chinese also has an impact! Some of the text is weird, it feels a bit like Japanese 0001 Screenshot_2024_1119_032630

@9mmarreimu, I saw a message about this issue today in #6626.

Withimag commented 2 weeks ago

Maybe there is an option to return the old "Verdana" fonts?

Evisneffo commented 2 weeks ago

Maybe there is an option to return the old "Verdana" fonts?

Personally, I don't want to revert to the old font because it's unattractive and outdated.

Withimag commented 2 weeks ago

This is me personally, I would return the font that was before, the absence of letters in the new font hurts the eyes very much

Withimag commented 2 weeks ago

I hope there will be knowledgeable people who can either draw the missing letters themselves or return the old font

Withimag commented 2 weeks ago

I tried to bring back the old font, but it just turned into a mess

GammaSan commented 1 week ago

Not only does Russian have an impact, Simplified Chinese also has an impact! Some of the text is weird, it feels a bit like Japanese 0001 Screenshot_2024_1119_032630

As far as I know that GorDIN font didn't include T+S chinese characters, however the missing characters will be replaced with Noto Sans CJK which the font file is located at "platform/resource/linux_fonts/notosanscjk-regular.ttc". I'd like to know if there is a path setting in conf or something to replace missing characters.

Withimag commented 1 week ago

Guys, I finally found the cyrrilic fix https://steamcommunity.com/sharedfiles/filedetails/?id=3367954466 That's who needs it

GammaSan commented 1 week ago

Guys, I finally found the cyrrilic fix https://steamcommunity.com/sharedfiles/filedetails/?id=3367954466 That's who needs it

Well I found that out for myself a couple days ago when i trying to change fonts. btw "notosanscjk-regular.ttc" that I mentioned above can also be replaced with same method.

misyltoad commented 1 week ago

Thank you for reporting, this should be fixed in the next update.

Evisneffo commented 1 week ago

Thank you for reporting, this should be fixed in the next update.

@misyltoad, Thank you so much!

Evisneffo commented 6 days ago

Thank you for reporting, this should be fixed in the next update.

@misyltoad, After the update was released, the issue was not fixed.

To fix the issue, it would be enough to add support for three letters in the font (Ёё, Ээ, Ыы). 20241127061411_1 20241127061452_1

VladWinner commented 5 days ago

November 26, 2024 Update. UI fonts updated for better support in Cyrillic languages.

The issue remains unresolved: image Beta branch also does not contain any changes to the font.