ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
660 stars 76 forks source link

[HL2DM] None of the 20th anniversary bugfixes were actually applied to HL2DM #6773

Open DisrespectDwardo opened 6 days ago

DisrespectDwardo commented 6 days ago

As title shows, none of the listed fixes i.e. "Fixed player model selection in the options menu." "Fixed view bob with the SMG equipped."

Instead the binaries with the code for these fixes was shipped inside of the Half-Life 2 singleplayer inside of the hl2mp folder. Nothing has been fixed with the 20th anniversary update, things have only been broken (vote menu, audio, etc.)

adelina1985a commented 4 days ago

@DisrespectDwardo Idk if latest update was AFTER your post, but today I tried player model selection from the Options Menu and it worked, whether I was on a server or not. I tried on my PC, laptop, and a fresh install on PC just to be sure. If you have a readonly config.cfg or an autoexec.cfg with cl_playermodel, the change(s) will only be applied to the session.

The Options Menu still has spray issues! Small FYI, changing the spray will only take effect when (re)joining a server. Big FYI, on a fresh install, the bind t "impulse 201" (the bind can also be done in Options->Keyboard) and cl_spraydisable 0 are needed, besides picking a spray. Onto the issues:

  1. Fresh install will have the Options Menu opening to a non-existent spray as the default, with missing texture icon. Even though it says 'spray_canned' in the menu, the cl_logofile is actually materials/vgui/logos/spray.vtf when checking the console. So new players will have no spray unless they do at least 1 console command (???), a bind, and pick a spray (in the options menu or console), or use the menu to just change the playermodel which will automatically pick the spray 'spray_canned.vtf'. How is a new player supposed to figure out this convoluted way for something that worked out of the box in hl1 etc?
  2. Once a spray is set, when relaunching the game, that menu will always default to spray_canned.vtf. The menu spray ignores the config. And the spray can accidentally get reset even when the intention is to ONLY change the playermodel.
  3. When changing a spray (menu/console), even if that change takes effect and writes a non readonly config, relaunching the game (re)sets it to that non-existent spray.vtf. Even if the config is made readonly, relaunching the game will still leave players unable to spray. The game ignores the config. Some temp solutions include:
    • manually changing the spray via menu or console at every launch, before joining a server; or
    • an autoexec with cl_logofile, in which case any further changes via menu/console will only last a session, and the logo value in the config.cfg will be ignored; or
    • a custom spray called 'spray.vtf' and a read-only config (to avoid issue 2). The custom spray can still look like the default ones, it just needs to be called 'spray.vtf'. That's how I got mine to work permanently. If any autoexec present, it needs to match the config or the autoexec will take precedence as mentioned.