VK_EXT_global_priority on AMD

ChristophHaag commented 6 years ago

As I understand it the somewhat undocumented setting enableLinuxVulkanAsync in steamvr.vrsettings should enable the usage of this extension and make use of amdgpu's high priority rendering in recent linux kernels.

The last thing I heard several months back was that the SteamVR compositor needs to be changed to do reprojection on a compute queue because only those can be run asynchronously (at the moment). Also it requires root or drm master permissions, so a kernel patch or drm leases is required.

Since then we've heard nothing.

Currently it does not seem to work and does not give a proper error message:

Fri May 18 2018 00:33:27.278940 - Requesting 8 device extensions:
Fri May 18 2018 00:33:27.278945 -  - VK_KHR_swapchain
Fri May 18 2018 00:33:27.278949 -  - VK_KHR_maintenance1
Fri May 18 2018 00:33:27.278952 -  - VK_KHR_dedicated_allocation
Fri May 18 2018 00:33:27.278955 -  - VK_KHR_get_memory_requirements2
Fri May 18 2018 00:33:27.278958 -  - VK_EXT_display_control
Fri May 18 2018 00:33:27.278961 -  - VK_KHR_external_memory_fd
Fri May 18 2018 00:33:27.278964 -  - VK_KHR_external_semaphore_fd
Fri May 18 2018 00:33:27.278967 -  - VK_EXT_global_priority
Fri May 18 2018 00:33:27.278970 - Attempting to enable async support...
Fri May 18 2018 00:33:27.278973 - Enabling async support!
Fri May 18 2018 00:33:27.281566 - Failed to create VkDevice with high priority queue.
Fri May 18 2018 00:33:27.281595 - Disabling async support and retrying.

That's the current state on latest SteamVR beta https://steamcommunity.com/games/250820/announcements/detail/1656641115372590275 RX 480 with radv git + drm lease patches https://github.com/ChristophHaag/mesa-mesa/commits/fe12582fe82d8891db81d3922c6049955178756d drm-next-4.18-wip kernel

ChristophHaag commented 6 years ago

For reference, I believe the setting is in the steamvr section in ~/.local/share/Steam/config/steamvr.vrsettings like

{
   "steamvr" : {
      "enableLinuxVulkanAsync" : true
   }
}

It still doesn't work.

Kernel support is there, radv support is there, steamvr is using drm leases, so why is it failing?

drawingpixels commented 6 years ago

Able to reproduce it here with Arch using git versions of mesa and xf86-video-amdgpu.

I was able to get it working by patching the kernel, just removing the check for drm-master/cap-sys-nice.

This makes the whole experience a lot smoother, the difference is pretty drastic.

ChristophHaag commented 6 years ago

I can confirm

Wed Jul 25 2018 09:58:13.715073 - Attempting to enable async support...
Wed Jul 25 2018 09:58:13.715085 - Enabling async support!

and then no error.

The first thing I tried with it was Everspace and it crashed the compositor

Core was generated by `/home/chris/.local/share/Steam/steamapps/common/SteamVR/bin/linux64/vrcomposito'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000435bac in CGenericResources::Update(vr::IGraphicsDevice::UpdateParams_t const&) ()
[Current thread is 1 (Thread 0x7f9054377700 (LWP 5291))]
(gdb) bt
#0  0x0000000000435bac in CGenericResources::Update(vr::IGraphicsDevice::UpdateParams_t const&) ()
#1  0x000000000041c1cf in vr::CHmdDistort::Update(vr::EVREye, vr::CHmdDistort::UpdateParams_t const*, vr::TrackedDevicePose_t const*, vr::ETrackingUniverseOrigin, unsigned long) ()
#2  0x0000000000454f43 in CRenderThread::UpdateAsync() ()
#3  0x0000000000459cb2 in CRenderThread::Run() ()
#4  0x0000000000512170 in SteamThreadTools::CThread::ThreadProc(void*) ()
#5  0x00007f908093f075 in start_thread () from /usr/lib/libpthread.so.0
#6  0x00007f908067453f in clone () from /usr/lib/libc.so.6

Zamundaaa commented 6 years ago

The same happens for me, too. Haven't had any crashes due to it... I think

Thu Aug 16 2018 21:40:16.068790 - Attempting to enable async support... Thu Aug 16 2018 21:40:16.068793 - Enabling async support! Thu Aug 16 2018 21:40:16.069016 - Failed to create VkDevice with high priority queue. Thu Aug 16 2018 21:40:16.069024 - Disabling async support and retrying.

ChristophHaag commented 6 years ago

The crash was only with the kernel patch and async support enabled.

When I tried again it worked without the crash. I think

NOTE: This beta has been updated with the following changes Crash fix

from https://steamcommunity.com/games/250820/announcements/detail/1707314220616643268 might have been a fix for this crash but I don't really know.

Zamundaaa commented 5 years ago

So is there a reason that this still doesn't work without patching the kernel? It's been a while. Especially in some less performing Proton games this would be very very useful to have working

ChristophHaag commented 5 years ago

https://www.phoronix.com/scan.php?page=news_item&px=AMDGPU-Linux-5.1-Initial-Fixes Sounds like progress.