ValveSoftware / csgo-osx-linux

Counter-Strike: Global Offensive
http://counter-strike.net
766 stars 68 forks source link

Usage of VK_EXT_graphics_pipeline_library (Vulkan GPL) causing not insignificant performance loss. #3764

Open CNR0706 opened 1 month ago

CNR0706 commented 1 month ago

Your system information

System Information: https://gist.github.com/CNR0706/e453aa38c4ec3dce4a1761f2bcac6cbb Steam Runtime Diagnostics: https://gist.github.com/CNR0706/e12f63dc649c1aac64c56e689107afe3

Please describe your issue in as much detail as possible:

Expected: Game performs the same with or without VK_EXT_graphics_pipeline_library enabled.

What happened: When disabling VK_EXT_graphics_pipeline_library the game gains an extra 20 - 40 FPS depending on the test.

Steps for reproducing this issue:

  1. Benchmark game with VK_EXT_graphics_pipeline_library enabled.
  2. Set RADV_DEBUG=nogpl variable.
  3. Benchmark game with VK_EXT_graphics_pipeline_library disabled.
  4. Rerun benchmarks with VK_EXT_graphics_pipeline_library disabled to make sure that shader stuttering is not affecting the results.
  5. Compare performance numbers.

Notes: This difference used to be gigantic (100 FPS or more difference). Updates to the game have closed the gap between VK_EXT_graphics_pipeline_library and no VK_EXT_graphics_pipeline_library quite a bit, however there is still a difference that (from what I can tell) definitely should not be there.

ericek111 commented 3 weeks ago

Indeed, running the game with RADV_DEBUG=nogpl results in significantly (~15+ %) higher FPS, at the cost of shader compilation stutters. I'm also using the RX 6700 XT.