ValveSoftware / csgo-osx-linux

Counter-Strike: Global Offensive
http://counter-strike.net
787 stars 69 forks source link

Usage of VK_EXT_graphics_pipeline_library (Vulkan GPL) causing not insignificant performance loss. #3764

Open CNR0706 opened 5 months ago

CNR0706 commented 5 months ago

Your system information

System Information: https://gist.github.com/CNR0706/e453aa38c4ec3dce4a1761f2bcac6cbb Steam Runtime Diagnostics: https://gist.github.com/CNR0706/e12f63dc649c1aac64c56e689107afe3

Please describe your issue in as much detail as possible:

Expected: Game performs the same with or without VK_EXT_graphics_pipeline_library enabled.

What happened: When disabling VK_EXT_graphics_pipeline_library the game gains an extra 20 - 40 FPS depending on the test.

Steps for reproducing this issue:

  1. Benchmark game with VK_EXT_graphics_pipeline_library enabled.
  2. Set RADV_DEBUG=nogpl variable.
  3. Benchmark game with VK_EXT_graphics_pipeline_library disabled.
  4. Rerun benchmarks with VK_EXT_graphics_pipeline_library disabled to make sure that shader stuttering is not affecting the results.
  5. Compare performance numbers.

Notes: This difference used to be gigantic (100 FPS or more difference). Updates to the game have closed the gap between VK_EXT_graphics_pipeline_library and no VK_EXT_graphics_pipeline_library quite a bit, however there is still a difference that (from what I can tell) definitely should not be there.

ericek111 commented 5 months ago

Indeed, running the game with RADV_DEBUG=nogpl results in significantly (~15+ %) higher FPS, at the cost of shader compilation stutters. I'm also using the RX 6700 XT.

polluxau commented 2 months ago

Id like to see if this is improved with mesa 24.2 as they redid GPL and made the shader compiling smaller in size

Changelog in 24.2⬇️

Defaulting to a new shader cache implementation, reducing filesystem overhead

https://docs.mesa3d.org/relnotes/24.2.0.html

CNR0706 commented 3 weeks ago

Just tested again on the latest Mesa release (24.2.5), and the issue is still there.

GPL: xT5iIci

no GPL: 3KXtH46

CNR0706 commented 3 weeks ago

I always test using the FPS benchmark map by Angel btw.