Assertion '!modifiers.empty()' when running gamescope in embedded mode

ValveSoftware / gamescope

SteamOS session compositing window manager

Other

3.13k stars 211 forks source link

Assertion '!modifiers.empty()' when running gamescope in embedded mode #1215

Open Erfboom opened 7 months ago

Erfboom commented 7 months ago

Using the following:

Intel UHD630
6.8.1-1-default linux kernel
Opensuse Tumbleweed
gamescope -W 2560 -H 1440 -r 120 -- moonlight in tty2 (embedded)

I receive Assertion '!modifiers.empty()' after a core dump. The program can be anything, not just moonlight.

When I run gamescope in nested mode, I can run things, but for moonlight specifically, once I activate a stream, I'll see a black frame in between every couple of good frames. If I use --expose-wayland, this will be reduced, but I'll trade it for choppiness in the stream on the native moonlight-qt, or smoothness with the AppImage variant but still the black frames.

If I run moonlight from terminal, no gamescope, the stream is as intended, smooth, no black frames.

EDIT: The flickering was caused by specifying the refresh rate in the gamescope command. Removing it causes the stream to be fine.

rien commented 3 months ago

I'm encountering a segfault as well on an Intel UHD620 - @Erfboom did you manage to work around this issue?

Erfboom commented 3 months ago

No, but I believe it's being worked on.

jpgrego commented 2 months ago

Same problem here, also with a HD620. Any news regarding this?

repomansez commented 2 months ago

Happening to me too, even when just launching gamescope by itself. UHD Graphics 620 on a ThinkPad T480

2goodAP commented 2 months ago

Yes, I too can reproduce this on NixOS with Intel GPU. I am using KDE Plasma 6.1.4. Also, the assertion failure only happens in nested mode. Everything works just fine for me under a separate tty.

I did some digging around and found this to be an issue for 3.15.x versions only. Nested mode works just fine for me up to commit 94271f3.

The 3.15.0 commit 28a4744, seems to have made some changes to DRM formats for composited outputs. That seems to be a possible cause for the assertion failure in nested mode only.

asukaminato0721 commented 1 month ago

it also failed on

GPU: Intel Iris Xe Graphics @ 1.30 GHz [Integrated]

repomansez commented 1 month ago

Upgrading to 3.15.9 completely fixed the issue for me. @jpgrego @2goodAP @asukaminato0721 @Erfboom can you guys try to update and see if it works too? Gentoo and NixOS specifically are shipping an out of date version of Gamescope.

2goodAP commented 1 month ago

Yeah 3.15.9 seems to have fixed it for me too. Thanks for the heads up @repomansez.

asukaminato0721 commented 1 month ago

arch updated to

[gamescope] [Info]  console: gamescope version 3.15.11 (gcc 14.2.1)

and it fixed for me too. Thanks for the heads up @repomansez.