search

ValveSoftware / gamescope

SteamOS session compositing window manager
Other
3.15k stars 213 forks source link

build: include missing gamescope_version for color utilities #1450

Closed matte-schwartz closed 3 months ago

matte-schwartz commented 3 months ago

looks like gamescope_version needs to apply to the two gamescope color utils following the logging convar in order to fix local builds (CI builds seem fine though)

fixes: https://github.com/ValveSoftware/gamescope/issues/1447

Billli11 commented 3 months ago

May be because ninja run jobs in parallel?
The compiler can't find the header if it is not created yet.
Build success when running ninja with -j 2.

matte-schwartz commented 3 months ago

May be because ninja run jobs in parallel? The compiler can't find the header if it is not created yet. Build success when running ninja with -j 2.

Ah yeah, reducing it down to that also seems to work around the build error. I was just using the default.

stele95 commented 3 months ago

Build success when running ninja with -j 2.

Using -j 2 also fixes the AUR gamescope-git package, but this feels more like a dirty fix instead of a proper solution