search

ValveSoftware / gamescope

SteamOS session compositing window manager
Other
3.15k stars 213 forks source link

Add gamescope-reshade Wayland interface #1495

Closed wheaney closed 2 months ago

wheaney commented 2 months ago

Implemented per the suggestion by @Joshua-Ashton in https://github.com/ValveSoftware/gamescope/issues/1082

misyltoad commented 2 months ago

Is there a client on this interface? I wonder if this is better served by gamescopectl and a gamescope::Command. That would make a client just work(tm).

wheaney commented 2 months ago

I've got a working client in this branch of my XR driver.

Can you expand on the gamescopectl and gamescope::Command suggestion?

Edit - just found this comment you made in our last conversion that led me down this path:

Steam uses the Gamescope Control protocol. Feel free to make a Gamescope Shader protocol or whatever.

wheaney commented 2 months ago

@Joshua-Ashton just waiting on more details.

wheaney commented 2 months ago

@Joshua-Ashton I'd love to get some more guidance or review feedback on this PR. I've got this integration working end-to-end locally with my own client, so it would be nice to wrap up or re-work if needed.

misyltoad commented 2 months ago

I thought more about it, and this is fine as-is really. It might be nice if you used the new stuff in src/WaylandServer to implement it though. It will probably end up a bit cleaner.

wheaney commented 2 months ago

@Joshua-Ashton Okay, thanks. Let me know what the next steps are for this.

misyltoad commented 2 months ago

I would like the Wayland server parts to use the new helpers there so we aren't adding more stuff for me to rewrite. Other than that it's fine.

wheaney commented 2 months ago

@Joshua-Ashton I think the latest commit covers what you've requested.

wheaney commented 2 months ago

@Joshua-Ashton Thanks for merging this! How often does the Preview channel get the latest gamescope updates? And what's the process and typical timeline for changes to migrate through the SteamOS channels? Is there documentation around that process?

misyltoad commented 2 months ago

It depends a lot, Main gets updated pretty regularly, and Beta whenever think we are ready to push on shipping Main.

Timelines are all over, and semi-made up.