ValveSoftware / gamescope

SteamOS session compositing window manager
Other
3.07k stars 204 forks source link

Gamescope 3.15.9 totally broken on my system #1530

Closed radek-stasta closed 6 days ago

radek-stasta commented 1 month ago

As I described here: https://github.com/NixOS/nixpkgs/issues/342512, current version of gamescope is totally broken on my system. Video: https://streamable.com/ls8zm0. Using Proton GE 9-13

matte-schwartz commented 1 month ago
❯ gamescope --version
[gamescope] [Info]  console: gamescope version 3.15.9 (gcc 14.2.1)

just checked and am not seeing any issue with Everspace 2's demo with either DX11 or DX12 on Plasma 6 Wayland (I don't own the full game to test):

Screenshot_20240917_095135

What launch command are you using? Any relevant logging from gamescope? What desktop environment, or are you talking about the DRM backend when run from TTY?

radek-stasta commented 1 month ago

I launch whole steam inside gamescope with: 'gamescope -w 2560 -h 1440 -f -- steam'. Im using NixOS with Hyprland. Maybe is something broken on my side, but Im now downgraded to 3.14.29 and everything is running just fine, only if I update gamescope those problems suddently appear

matte-schwartz commented 1 month ago

that also works fine for me. sounds like a hyprland issue. you can also try making sure youre using ENABLE_GAMESCOPE_WSI=1 although it probably won't do anything in this instance.

radek-stasta commented 1 month ago

gamescope.log gamescopeWorking.log

Logs from working and not working runs

radek-stasta commented 1 month ago

And yes, setting that variable does not have any effect. It might be hyprland or maybe NixOS, but still something must have changed, since it is working all right with previous version

matte-schwartz commented 1 month ago

in your case it's likely https://github.com/ValveSoftware/gamescope/commit/ef3ff8a62a32458d5811768c7c8be5337a6610f5 that caused this issue. probably something to do with how Hyprland interacts with explicit sync since it works fine on Plasma 6 Wayland/X11. don't think this is our bug but rather a different bug that gamescope's implementation exposed. if you set https://github.com/ValveSoftware/gamescope/blob/d87f6d9b9d98ea8064e4063c01d483895fef87f0/src/Backends/DRMBackend.cpp#L70 to true and re-compile, gamescope might work for you again.

radek-stasta commented 4 weeks ago

I'm sorry, I don't have enough knowledge how to compile it myself and how to then push to NixOS package so I can test it on my system :(

radek-stasta commented 1 week ago

So I finally had time to revisit this problem. I created my own fork here: https://github.com/radek-stasta/gamescope and modified the line you suggested: https://github.com/ValveSoftware/gamescope/compare/master...radek-stasta:gamescope:master#diff-98121d8bfe66603c83b25acbf33ccea585feb869e4759d9f510d79a9bedf6f6b And indeed the gamescope is working correctly as before without any issues. Can I do something more about it or is there a way how to use fix this on some side so I can use official release and not my forked version?

zeptic99 commented 1 week ago

So I finally had time to revisit this problem. I created my own fork here: https://github.com/radek-stasta/gamescope and modified the line you suggested: master...radek-stasta:gamescope:master#diff-98121d8bfe66603c83b25acbf33ccea585feb869e4759d9f510d79a9bedf6f6b And indeed the gamescope is working correctly as before without any issues. Can I do something more about it or is there a way how to use fix this on some side so I can use official release and not my forked version?

Wow, this fixed "The Finals" for me. Valve should definitely look into fixing this!

radek-stasta commented 1 week ago

https://github.com/radek-stasta/gamescope/releases/tag/3.15.13 Updated to 3.15.13 until we get some official info

matte-schwartz commented 6 days ago

Still unable to repro here... I am pretty sure this is not our bug tbh, if that workaround did help for you it seems like we're just avoiding some Hyprland issue :/

radek-stasta commented 6 days ago

So what is the correct solution here? Expose this issue to Hyprland team?

matte-schwartz commented 6 days ago

Likely yes, although I don't know how Hyprland issue reporting works. you have a decent amount of useful info now that you know disabling explicit sync makes it work again.

radek-stasta commented 6 days ago

Im closing this issue and will keep my repository updated with gamescope releases until it is resolved somehow. Thanks for support