ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.72k stars 625 forks source link

[GoldSource - Suggestion] Add snapshots_enable 1/0 cvar #1086

Open ghost opened 11 years ago

ghost commented 11 years ago

Some server plugins take snapshots on a client every X minutes. Let's assume this situation: Plugin takes a snapshot every 15 minutes, you play 3 hours every day, 1 screenshot = 3mb 12 screenshots every day within a week = -252mb freespace In a month it's 336 screenshots - almost 1GB and there's no way to prevent this.

hotactions commented 11 years ago

+1 fully agree with you, there exists some kind of slowhacking plugins that even works with cl_filterstuffcmd, massively sending snapshot, screenshoot commandst to client, in result counter-strike crash.

Freeman-AM commented 11 years ago

Please don't break the screen ban feature... (only 3 screen taken when the ban is applied, not a kind of slowhack here)

Stop playing on these kind of servers. You need to be stupid to don't see the screen taken. it freeze your CS !

In france we have no problem with slowhacker because there is not that many. Please fix problems with your country players before doing this kind of suggestion. xD

And please don't say the blablabla not country related. Count the number of Western european redirection server compared to eastern european redirection server. This is corellated to slowhack, trust me.

ghost commented 11 years ago

omg... stop crying over it. I suggest a cvar and obviously it'll be 0 by default.

Freeman-AM commented 11 years ago

I just don't like the way it take. punish the whole community when the problem is only 5% of server owners. It's like killing 100 people because in these 100 people there is 5 killers in it.

ghost commented 11 years ago

Please calm down and think! I suggest a cvar and its value will be 0 by default. You have nothing to worry about! Right now you are punishing 5% of community who don't like game folders overflowed with useless screenshots!

Freeman-AM commented 11 years ago

I guess that if you ask this, it's because you continue to play on theses servers. Playing on this kind of server mean for me that you support owners acts.

By asking this, there is : a risk that alfred put it to 1 by default, that i absolutly don't want. a risk that people use this to avoid ssban.

That why i'm against this stuff.

ghost commented 11 years ago

What do you mean "avoid ban"? If you want to ban somebody you don't need his permission or screenshot. Screenshot is a proof of innocence, not an excuse. If I'll be banned on some server and I use this cvar, then it's my problem and I won't try to contact server admins with no evidence that I don't cheat. And I'll say it for the hundredth time: if I don't like 1 plugin on a perfect (low ping, good admins, good players) server, I will not search for another place to play, but I don't want to waste freespace on my SSD/HDD and manually clean game folders

hotactions commented 11 years ago

lol it just screenshoots, and allowing todo them without user access is considered as slowhacking, please add the option, romanian, russian kids above crying, also add server control all servers should be controlled by valve, they must register just like getchallenge working, this prevents dproto and completely breaks nonsteam servers, to ensure safe of this avoiding cracks, the engine should be recoded every 6months, i bet alooooot of people won't agree with me, but this should be done to entirely stop no-steam.

MichaelZer0 commented 11 years ago

And what prevents you delete these screenshots? Make a *.bat file and add it to autostart, and then cstrike folder will be cleaned from the screenshots at every start of the computer. Yes, and the statistics: "Less than 10 GB - 2.11%" so it's not much of a problem, moreover, necessary thing, it is not for nothing was it implemented with the help of plug-ins. And besides, no one forces you to play on this particular server! Developers and so do not have time to fix all bugs, crashes, the lag after the transfer under LINUX, and many of them could not even run CS once removed D3D And you about which there screenshots are worried, people play can't and then endure.

ghost commented 11 years ago

http://www.thingist.com/item/4372/

ghost commented 11 years ago

it is possible to spam screenshots to death if you have admin rights and cause a client to crash

this plugin is also a nonsense in the meaning that any hack is hooking the engine function bound to the snapshot command and panic-disabling when a screenshot is taken... or what if the hacks visuals are drew in an overlay window ? admins using this plugin are naive

txdv commented 11 years ago

Just add the possibility to change the output format. A screenshot on my 1680x1050 display takes 5mb when saved in bmp. When I converted it to jpg - 300kb, png - 1.4mb.

Use jpg as the default if nothing is specified, "snapshot bmp" for bmp, "snapshot png" for png and "snapshot jpg" for jpg.

Furthermore add the possibility to add some kind of prefix, so admins can associate the screenshots with a single server.

kriswema commented 11 years ago

Maybe @alfred-valve could tell us if it's possible to make a command only locally callable / externally inaccessible. That would probably the solution we're looking for here? I feel like servers shouldn't have access to player variables anyways. What is this needed for?

ghost commented 11 years ago

I feel like servers shouldn't have access to player variables anyways. What is this needed for?

I totally agree, such things are used for admin abuse exclusively anyways but as far as I know there is already commands that admins can't make you execute anymore now but I am not sure about accessing a player variable, this should still be possible with the engine function