Extending some engine limits

Arkshine commented 11 years ago

It would be a good opportunity to slightly increase some max values.

Proposed limits are based on http://code.google.com/p/sing-engine/. Relevant limits and value would be :

MAX_MODELS 1024 (default: 512)
MAX_SOUNDS 1024 (default: 512)
MAX_BEAMS 256 (default: 64)
MAX_TEMPENTS 1024 (default 500)
MAX_MAP_MODELS 512 (default: 256)
MAX_MAP_LEAFS 16384 (default: 8192)

I think it's fair values. Of course higher values are welcomed (like Sing) but as it is it would be already really useful and awesome.

It will contribute to make everyone happy : the mappers would be able to do better maps (larger/more detailed/etc..), the coders will have more room to do custom stuffs, the admins will see their servers crashing less often, and the players will see their gaming experience improving.

Thanks for considering those changes, which are, I think, quite reasonable and realizable.

sw5ciprl commented 5 years ago

GoldSource is based heavily on the Quake engine - lots of the internals are similar or the same but stuff like coloured lighting, per-texture palettes and client and server .dll files were added.

id Software should've forgiven that. ;)

ThomasJaeger commented 5 years ago

Has anyone tried increasing these limits and compile the server and tested them? If not, I would be willing to make these changes.

twisterniq commented 5 years ago

Has anyone tried increasing these limits and compile the server and tested them? If not, I would be willing to make these changes.

As far as I know, these limits are not only server-side, but client-side too.

ThomasJaeger commented 5 years ago

I'm trying to solve the

"PF_precache_model_I: Model 'models/[pickyourmodel]' failed to precache because the item count is over the 512 limit."

precache error specifically. This only occurs on the server side.

twisterniq commented 5 years ago

I'm trying to solve the

"PF_precache_model_I: Model 'models/[pickyourmodel]' failed to precache because the item count is over the 512 limit."

precache error specifically. This only occurs on the server side.

If you increase it, client just will have bugs with that models/sprites... IIRC, he just will not be able to see new models. At the moment, we can use Ultimate Unprecacher to unprecache unused models/sprites...

ThomasJaeger commented 5 years ago

Thanks for the Unprecacher but that seems very hacky and won't really guarantee a clean solution. Looking at the source code, I see the following for example:

#define MAX_MAP_MODELS 400

in file \halflife\utils\common\bspfile.h which is used in several places. I have never compiled the goldsource. Where is the client source code? Is it even available? Or am I just missing it somewhere?

ThomasJaeger commented 5 years ago

I just realized that the client can't be part of the repo because the steampipe is distributing the clients by Valve. So, even I could compile the client it won't help since players will get the clients always from Steam.

RauliTop commented 5 years ago

I just realized that the client can't be part of the repo because the steampipe is distributing the clients by Valve. So, even I could compile the client it won't help since players will get the clients always from Steam.

Of course, that's why Valve is the only who can achieve it.

uniarch commented 5 years ago

So? Dear Developers, I have only 2 questions for you. Is it possible to extend the limits? If the first is true: Will you extend them in the future? I just want clear answers from the real workers. Thanks!

Yes, but doing so will break compatibility with older clients, such as No-Steam/cracked clients. That's a big decision to make.

This issue is a candidate for a future release so it's pretty likely.

The network protocol will need a major revision to support higher limits since even the current limit can't be fully utilized. See #2534 for that.

no-steam - no-support. also they always adapt to changes, so don't care about it much

y2keeth commented 2 years ago

yes please do this

TheArtemMaps commented 2 years ago

for god sake valve pls do this i begging y'all

ENTPRESTIGIOUS commented 2 years ago

for god sake valve pls do this i begging y'all

highly doubt it will ever happen if it didn't even happen before.

buracat commented 1 year ago

what is stopping you from doing this?

Maxi605 commented 1 year ago

what is stopping you from doing this?

Who exactly are you addressing? People can't do anything about this, the changes need to come from Valve itself.

zapy85 commented 1 year ago

what is stopping you from doing this?

Who exactly are you addressing? People can't do anything about this, the changes need to come from Valve itself.

Most likely against Valve.

what is stopping you from doing this?

The mere fact that Gold Source is from 1998, not that many engineers left at Valve that have the knowledge how that engine is put together and would likely need some massive time to get custom to it. Many other things will presumably stop working as well that needs updated for this to work. @alfred-valve you have any comments? its quite dead from Valve in form of new games over all, is there more steam platform development and management today than producing new games? @mikela-valve maybe have some news, i see that its on a to-do list since 2020 :o

snarks567 commented 1 year ago

A decade of nothing, sad.

deathreaperz commented 7 months ago

I've been trying to add a new weapon, but all the weapon animation, sounds, muzzleflashes and zoom ability won't work. Is these engine limits causing those errors?

Maxi605 commented 3 months ago

@shawns-valve this is mostly (if not entirely) done with the 25th anniversary update. Should be closed and if you see fit, implement new values recommended if not done already.

tschumann commented 3 months ago

Which limits haven't been increased?

On Sun, 1 Sept 2024 at 14:44, Maxi @.***> wrote:

@shawns-valve https://github.com/shawns-valve this is mostly (if not entirely) done with the 25th anniversary update. Should be closed and if you see fit, implement new values recommended if not done already.

— Reply to this email directly, view it on GitHub https://github.com/ValveSoftware/halflife/issues/12#issuecomment-2323165279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA34IYTWKBKD4SZCL6MJTW3ZUKLTHAVCNFSM4ADOVB3KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMZSGMYTMNJSG44Q . You are receiving this because you commented.Message ID: @.***>

marigi64 commented 3 months ago

I'm fairly sure the beam limit hasn't increased since https://github.com/ValveSoftware/halflife/issues/3087 is still an issue.

zapy85 commented 1 month ago

Replying to https://github.com/ValveSoftware/halflife/issues/12#issuecomment-2323206835

Increased maximum limit of dynamic sound channels from 8 → 32.
Increased maximum limit of sentences in the sentences.txt file from 1536 → 2048.
Increased maximum number of entities (MAX_EDICTS) from 900 → 1200.
Increased MAX_PACKET_ENTITIES increased from 256 → 1024.
Increased MAX_GLTEXTURES from 4800 → 10000.
Increased software renderer geometry limits: max spans 3000 → 6000, max surfaces 2000 → 4000, and max edges 7200 → 14400.
Cycler and func_button entities can now be the entity target for scripted_sentence entities, and are allowed to speak in multiplayer.
Incorporated func_vehicle entity support from Counter-Strike, for mod-makers to use. Full SDK update will come later, but level designers can use it now.

Albeit not a programmer i have followed this for long and completely missed the 25th aniv... https://www.half-life.com/en/halflife25/ scroll to the end for all the updates, its big.

ValveSoftware / halflife

Extending some engine limits #12