ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.72k stars 625 forks source link

Windowed mode: Windows task bar overlays the game #157

Closed Adambean closed 11 years ago

Adambean commented 11 years ago

I currently run Half-Life in windowed mode at the same resolution as my screen. Nice to see the engine has its' own native mode to make the window borderless now.

There is a small issue though, the Windows task bar always overlays the game, even when it's active. I've alt+tab'd out and back in, and it's still there.

In Sven Co-op we did implement our own way to make a window borderless, but combined with the new engine method this caused problems (made the window smaller again). We've disabled this feature and tried again before reporting this issue. This issue also occurs in Half-Life for me, not just our mod.

I'm running Windows 7 Professional x64.

misfire commented 11 years ago

I can confirm this happens to me as well.

di57inct commented 11 years ago

Same here.

Adambean commented 11 years ago

Related note: If you right click the game in the task bar (SHIFT + RIGHT CLICK for Windows 7+ users) and select Maximize, the task bar no longer overlays the game when you switch back to it.

ghost commented 11 years ago

that's what you mean? If so, it fixes by adding -noborder parameter, but, in my case, you'll get two lines, one on the right side and another in the bottom (I could show you a screenshot, but you won't see the lines because of white background) Dup of https://github.com/ValveSoftware/halflife/issues/130

Adambean commented 11 years ago

The problem isn't that there is a border visible, it's that the game appears to be maximized in a borderless window (thus filling the screen), but the Windows task bar overlays the game.

ghost commented 11 years ago

that's what you can see on my screenshot, isn't it?

ghost commented 11 years ago

I can't "maximize" the game in a borderless mode. I can't call a SHIFT + CLICK menu on a borderless window

Adambean commented 11 years ago

I couldn't until this minute (it wouldn't load all the way). Our game looks similar, but we don't have that faint white line on the far right of the game. Odd that you can't bring up a context menu for Counter-Strike in the task bar. You are right clicking yes?

Also it appears the maximize trick only works on Sven Co-op 4.7 anyway, in conjunction with our own borderless feature.

ghost commented 11 years ago

I can call the context menu if I don't use -noborder parameter.

Adambean commented 11 years ago

I can't test this in CS 1.6 as mine doesn't seem to update (even though I've opted in for the beta). I can confirm my Half-Life is up to date though (version 1.1.2.2 build 5956).

Edit: I don't use the -noborder option. Such an option is rather pointless if the game resolution as defined in the options is already set to cover the whole screen resolution. Anyway, I've emailed in a code snippet to fix this issue.

alfred-valve commented 11 years ago

If you want your window to occupy the whole desktop use fullscreen, windowed mode is only meant for resolutions less than the desktop. We have changed the fullscreen mode to behave well with alt tab so you don't need to choose windowed to work around that (just don't run with "-nofbo" ).