search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.67k stars 622 forks source link

CPlayerListDialog::Activate leaks KeyValues objects if player name is empty #1805

Open SamVanheer opened 7 years ago

SamVanheer commented 7 years ago

If a player's name is empty, CPlayerListDialog::Activate will leak the KeyValues object allocated in the loop. Given that unconnected clients may return a null pointer, this can leak maxClients - currentPlayers KeyValues instances (24 bytes each) every time the dialog is activated.

SamVanheer commented 5 years ago

@mikela-valve Worth looking into i guess?