ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.74k stars 631 forks source link

[Op4CTF] Long Jump Rune #1857

Open APGRoboCop opened 6 years ago

APGRoboCop commented 6 years ago

Hello I've noticed on Op4CTF Linux server that the LJ Rune doesn't appear to work when I duck jump forward. I not sure if all the DeathMatch maps of Op4 with the Long Jump module is affected as well but it should be running fine on op4crossfire, from what I've recently tested. Also when I switch from a op4ctf to a op4_ map the "Time Remaining" HUD appears to remain in DeathMatch maps. And no biggie but is it possible to increase the column width and character limit for the Scoreboard as well please?

20:18:15 Protocol version 48 Exe version 1.1.2.2/Stdio (valve) Exe build: 17:35:12 Jul 5 2017 (7559)

tschumann commented 6 years ago

Yeah I've seen the Time Remaining remain too (even in single player I think).

SamVanheer commented 6 years ago

The CTF long jump item sets the jpj physics keyvalue to 1, the original longjump item sets slj to 1. No checks exist for jpj, only slj as in the SDK.

As for the timer, CHudFlagIcons::m_bIsTimer is set by a message function which is only used by CTF gamerules. It is reset in CHudFlagIcons::Init, which is called by CHud::Init, which is called by HUD_Init, which according to the comments is supposed to be called every time the client connects to a server. This is not true in the current engine build so that change probably broke it.

To fix this, VidInit may used, as it is called every time the client connects to a server. HUD_VidInit -> CHud::VidInit -> CHudFlagIcons::VidInit.

henning-f commented 2 years ago

@SamVanheer I saw all duplicate issues to this one and I tried using a AMX Mod based fix but it won't solve the issue. Is there any outlook to when this fix will be released? All tickets have been marked with fix proposed and even there was set a "milestone" but I do not see any progress after three years. I do not have Windows servers and would really like to set up some proper OP4 CTF server.

SamVanheer commented 2 years ago

As far as i can tell there is nobody actively working on GoldSource engine games so i wouldn't expect any fixes from Valve.

My Opposing Force SDK is almost ready for a full release so that could be an alternative option, but it doesn't support crossplay with the original Opposing Force.

djearthquake commented 2 years ago

@lith01 The jump aspect runs off fakemeta. Assure the module is working in Amxx please. https://github.com/djearthquake/amxx/blob/main/scripting/gearbox/op4ctf_jumpfix.sma. Also if logging is off it won't work. LOGGING MUST BE ON!

fm_set_user_longjump(target, true, true)

https://forums.alliedmods.net/showthread.php?t=317504 Welcome to the community.