Open metita opened 5 years ago
SamVanheer
commented
5 years ago Muting chat from this dialog is difficult because this dialog exists in GameUI while chat is handled entirely by game code. An interface would need to be exposed to communicate this information to client.dll.
metita
commented
5 years ago Muting chat from this dialog is difficult because this dialog exists in GameUI while chat is handled entirely by game code. An interface would need to be exposed to communicate this information to client.dll.
@SamVanheer is there a purpose on being able on muting yourself? Seems like a bug to me.
SamVanheer
commented
5 years ago Muting chat from this dialog is difficult because this dialog exists in GameUI while chat is handled entirely by game code. An interface would need to be exposed to communicate this information to client.dll.
@SamVanheer is there a purpose on being able on muting yourself? Seems like a bug to me.
They probably didn't think of it. There's nothing in GameUI's player list that checks if the index matches anything.
All it does is hand the command over to the client dll: https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/cl_dll/cdll_int.cpp#L406-L447
A new version of this interface can be created to support chat muting. Backwards compatibility should be easy to do with this, if version 2 is unavailable get version 1 and create a wrapper that does nothing for chat muting.
afwn90cj93201nixr2e1re
commented
5 years ago At HL we can mute player in tab, but at cs can't. The money in the table is unnecessary, do not make the game similar to CS:GO or create a cvar to disable them, by default they must be disabled. Once the TAB is refactored, you can add block the player voice chat from it. Also player mute list now saved like: playerid(number):true/false, it's must be fixed like: *sid:true/false, because after connect to another server/restarting game this list save's in cstrike dir. @mikela-valve @kisak-valve add feature request counter-strike.
twisterniq
commented
5 years ago The money in the table is unnecessary, do not make the game similar to CS:GO or create a cvar to disable them, by default they must be disabled.
No need to talk here about this. The issue regarding money in TAB: https://github.com/ValveSoftware/halflife/issues/702
I think this tab should be improved.
1) Being able to perma-mute voice for a specific user. (Not sure how is this working at the moment if is only in the actual session or already permanent) 2) Add a new mute to block chat messages for a specific user. 3) Add a "Refresh" option on the menu itself so we don't need to click on "Player List" again. 4) "Unmute in-game voice" gets truncated and gets displayed as "Unmute in-game voic" (on 1920x1080, not tested on different resolutions) 5) Fix being able to mute yourself.