ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.69k stars 622 forks source link

"gl_ztrick_old" should be deleted as it is already deprecated. #2337

Open metita opened 5 years ago

metita commented 5 years ago

Title.

This was added on the Update from 15 Feb, 2013

This cvar has to be deleted from the game, not sure why this was implemented into the game as an *_old cvar as it is useless.

from the changelog itself: Renamed gl_ztrick cvar to gl_ztrick_old, usage of this cvar is deprecated and caused rendering issues

ghost commented 5 years ago

gl_ztrick_old = Z-buffer half range, but no clears (saves fill rate). Enabling this might cause distant objects to flicker. If you want more fps, enable this.

This command works fine, at least for me. Gives increase FPS.

ghost commented 5 years ago

Don`t remove this please!

ghost commented 4 years ago

We need to fix problems with Z-Fighting, not make them worse. I don't understand... Doesn't this command fix problems with Z-Fighting? I haven't used it in Half-Life, but I remember using it in Quake, and it fixed major problems with Z-Fighting. Either that or it was called zfix... I cant remember honestly. A light fixture in Crossfire has this Z-Fighting issue and it's quite harsh on the eyes. I'm just confused. I don't know a lot about this, but I have experimented with it.

SamVanheer commented 4 years ago

ZTrick doesn't deal with Z-fighting, it deals with rendering performance by eliminating the need to clear the buffer at the start of a frame.

Here's the original documentation for that variable: https://github.com/id-Software/Quake/blob/bf4ac424ce754894ac8f1dae6a3981954bc9852d/WinQuake/docs/readme.glquake#L131-L134

gl_ztrick 0
Glquake uses a buffering method that avoids clearing the Z buffer, but some 
hardware platforms don't like it.  If the status bar and console are flashing 
every other frame, clear this variable.