search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.75k stars 630 forks source link

[CS1.6] Do not allow overwriting of .dem files. #2593

Open Automatics opened 5 years ago

Automatics commented 5 years ago

Please append _1 to end of new demo instead of deleting old demo of same name.

uniarch commented 5 years ago

I think better solution will be adding map+date+time stamp like it's done on hltv

afwn90cj93201nixr2e1re commented 5 years ago

+1. Timestamp's not a good idea.

twisterniq commented 5 years ago

It's a really bad idea to not allow it. We'll get a lot of trash.

CS-PRO1 commented 5 years ago

I'm both with and against. Sometimes I lose important demo footage due to overwriting. On the other hand tho, most demos would take useless space. Better keep it as a Cvar or to have a dialog for choosing to replace/rename. Just like Windows..

JoelTroch commented 5 years ago

Make a CVAR to please both worlds.

afwn90cj93201nixr2e1re commented 5 years ago

and make cvar's for block writing demo from server side too, and set it by default 1.

10th commented 5 years ago

and make cvar's for block writing demo from server side too

It is better to specify in this cvar how many seconds after connection to start recording: -1 (do not record) 0 (record without delay) 30 (record after 30 seconds)

and set it by default 1.

Very doubtful.

afwn90cj93201nixr2e1re commented 5 years ago

Hm. Normal server's start recording demo files on jointeam, other's after connection and etc.

10th commented 5 years ago

start recording demo files on jointeam

This is only relevant if the demo is not overwritten. And for a re-recording demo, it's always better to make a delay. Can be done so: 0 - do not record 1 - record on jointeam 2-60 - record with delay to file "server name" or "IP+port" or cvar_dem_name...

afwn90cj93201nixr2e1re commented 5 years ago

Lol, What? We shouldn't re-record demo files at all. there 2 way's block record command from server block rewriting demo-files from server incoming record cmd, so, then server's must save demoname's and this is the best option. But i prefer block record cmd from server at all. We shouldn't rework it. Demo record cmd accept arg's.

10th commented 5 years ago

Oh, sorry, I misunderstood your suggestion initially. We talk about different things.

afwn90cj93201nixr2e1re commented 5 years ago

No, i get you. It's just tip. https://github.com/ValveSoftware/halflife/issues/2593#issuecomment-513470742 That jointeam can be triggered before cooldown is end. Like you joined to server and joined to team, and it takes 10 second's, and server send on jointeam record blablablademo, but you have 30 second's cooldown, then record command will be rejected.