ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.71k stars 625 forks source link

[CS] [Windows] cl_minmodels still behaving oddly. #28

Closed zp closed 11 years ago

zp commented 11 years ago

Whenever I connect to an updated server after the non-beta cs release, I see minmodels correctly, then after like 10-15 seconds of being connected all the models will change back to their player selected models. All further tinkering with minmodels does nothing after this happens.

It works fine if I create my own listenserver and test it out by killing myself, skins update correctly and such.

Does everybody on the server have to be updated to the steampipe version for minmodels to function correctly?

208.146.44.38:27015 is the ip of the server I'm playing on.

alfred-valve commented 11 years ago

It should only need your client updated, I'll test it some more.

zp commented 11 years ago

This may be an amxmodx issue, they've released an update for it that addresses some bugs related to counter-strike offsets. I'm talking to the server owner to try to get him to update amxmodx / metamod.

I'll report back whenever he gets it all updated to see if the issue still persists.

alfred-valve commented 11 years ago

Ahh 3rd party plugins, my old nemesis ;-)

zp commented 11 years ago

Ok, did some local testing and can confirm that it's an amxmodx issue.

Works fine on stock steamcmd hlds's and with only metamod, borks with amxmodx. I'll bring it to the amxx devs attention.

Closing.

zp commented 11 years ago

Ok, did a little bit more testing.

It seems to be an issue with the ClientPrint and UTIL_ClientPrintAll hlsdk utility functions. (possibly more)

I made a simple linux metamod plugin that has the following cmds for testing

When either of these commands get called, it breaks minmodels and resets back to player chosen models. It stays broken until I restart the game.

Seems to be why it broke after 10-15 seconds when joining a server, because amxmodx has a default plugin that calls a client_print function 15 seconds after joining the server.

So technically not an issue with amxmodx I suppose.

idderf commented 11 years ago

+1 for this

zp commented 11 years ago

Another update.

It seems to be a specific issue with HUD_PRINTTALK / print_chat

All function correctly and don't break minmodels.

HUD_PRINTTALK will still print the string to the chat window, but it breaks minmodels for some reason.

idderf commented 11 years ago

@alfred-valve please note that this issue has been re-opened

zp commented 11 years ago

So gmsgSayText (UTIL_SayText) works fine when printing strings/chat to the chat window, doesn't break cl_minmodels

gmsgTextMsg (ClientPrint/ClientPrintAll) only breaks minmodels when msg_dest is HUD_PRINTTALK / print_chat.

I'm fairly sure addons like amxmodx use gmsgTextMsg to do most of their string printing, because it can output to several locations and not just the chat window.

zp commented 11 years ago

video showing breaking of minmodels: http://www.youtube.com/watch?v=-WeeCsoxECk

metamod linux plugin src: https://gist.github.com/zp/9e7138edc4d3e761e3a7

edit: Also when you do cl_min_ct 10, and cl_min_t 11, the models become invisible for that team.

Corre1ation commented 11 years ago

What is the updated build number? I have a Windows HLDS on my PC (build 5758) with AMXModX 1.8.1 and Metamod 1.19p32 running and never noticed a problem with minmodels playing on it today. I tried to update it with hldsupdatetool but nothing happened. Don't want to update AMX and MM for now.

zp commented 11 years ago
] version
Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
Exe build: 14:30:42 Feb 15 2013 (5958)

Is the latest beta client version

version :  48/1.1.2.7/Stdio 5956

Is the latest non-beta server version.

You need to use SteamCMD to get the latest hlds now.

alfred-valve commented 11 years ago

I can reproduce this here with the "timeleft" command, debugging it now.

alfred-valve commented 11 years ago

How the heck did this code ever work, sigh. Found and fixed.

MaximilianKohler commented 11 years ago

@alfred-valve this is still broken. Join any of these servers with amx mod plugin:

67.215.246.76:27015 67.215.246.76:27017 67.215.246.76:27016

cl_minmodels works but not min_ct or min_t

Exe build: 17:09:07 Feb 18 2013 (5961)