search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.65k stars 617 forks source link

[GoldSrc] SV_ParseConsistencyResponse vulnerability #2980

Open magister4813 opened 3 years ago

magister4813 commented 3 years ago

Screenshot_2

Users can exploit this by sending a fake clc_fileconsistency with length <= 0, causing hlds to close. Sys_Error should be replaced with Con_Printf/Con_DPrintf.

SamVanheer commented 3 years ago

The client should also be dropped from the server if this happens.

Splatt581 commented 3 years ago

Same for _SV_ParseMove_:

image

RauliTop commented 3 years ago

@kisak-valve This issue needs to be tracked at ToDO list

fire64 commented 1 year ago

It's 2023 and the bug hasn't been fixed yet. Just checked it by sending incorrect clc_fileconsistency to my server. As a result, the server crashed.

The server has been updated to the latest version, the error persists.

WhiteMaterials commented 1 year ago

Bad valve developers cant fix this issue

WaLkZa commented 1 year ago

It's 2023 and the bug hasn't been fixed yet. Just checked it by sending incorrect clc_fileconsistency to my server. As a result, the server crashed.

The server has been updated to the latest version, the error persists.

Try with ReHLDS