search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.69k stars 622 forks source link

[HL] Scientist don't make remarks on bad smells #2982

Open Maxi605 opened 4 years ago

Maxi605 commented 4 years ago

As Guards, Scientist were supposed to make a remark when there's something dead near them, but this seems to be broken.

https://youtu.be/1tvz0WVaQGg?t=62

SamVanheer commented 3 years ago

This is because the Scientist's sound mask doesn't include carcasses, meat and garbage: https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/dlls/scientist.cpp#L772-L783

Barney's sound mask handles these cases correctly: https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/dlls/barney.cpp#L243-L256

Using the same one should fix it.

Thanks to NongBenz for letting me know about this.