search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.72k stars 624 forks source link

Conditional statement with identical lines in each branch. #3047

Open malortie opened 3 years ago

malortie commented 3 years ago

In ev_hldm.cpp, in EV_FireMP5, the following code has identical lines in each branch.

https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/cl_dll/ev_hldm.cpp#L708-L715

It should only use one line.

malortie commented 3 years ago

@kisak-valve Please, could you change the label to Half-Life or remove the label Deathmatch Classic ?