ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.55k stars 594 forks source link

Inconsistency of icon orientation on the taskbar #3744

Open FreeSlave opened 4 months ago

FreeSlave commented 4 months ago

After the anniversary update some mod icons appear to be vertically mirrored on the taskbar (at least for me on Linux).

E.g. I have a sample mod directory with "gearbox" as fallback_dir, so it uses game.tga from gearbox/ directory. The icon for this mod appears flipped on the taskbar. image Opposing Force itself however doesn't exhibit such issue.

Another mod example (Half-Life: Induction). You can see the lambda is flipped. image

This isn't an issue on the steam_legacy branch.

I also noticed the change to the valve/game.tga was introduced with the anniversary update. In the old version it had Orientation: TopLeft and in the current version it's Orientation: BottomLeft. I guess something has changed to what tga format is expected by the game and it affects mods.

All I want to know is whether this change will be reverted/fixed in future. Or should we stick to BottomLeft orientation for game icons from now on? (which on other hand would look flipped on the steam_legacy branch).

tschumann commented 4 months ago

I might be wrong but I thought it was changed to TopLeft some time in the last decade (because I had some trouble getting my mod to show the icon the correct way).

On Thu, 11 Jan 2024 at 17:43, Roman Chistokhodov @.***> wrote:

After the anniversary update some mod icons appear to be vertically mirrored on the taskbar (at least for me on Linux).

E.g. I have a sample mod directory with "gearbox" as fallback_dir, so it uses game.tga from gearbox/ directory. The icon for this mod appears flipped on the taskbar. image.png (view on web) https://github.com/ValveSoftware/halflife/assets/5596503/7ac06e92-ef3d-4c81-a4a5-bb7513e6a701 Opposing Force itself however doesn't exhibit such issue.

Another mod example (Half-Life: Induction). You can see the lambda is flipped. image.png (view on web) https://github.com/ValveSoftware/halflife/assets/5596503/4642fdf6-6698-4d72-8371-5298e4820b0a

This isn't an issue on the steam_legacy branch.

I also noticed the change to the valve/game.tga was introduced with the anniversary update. In the old version it had Orientation: TopLeft and in the current version it's Orientation: BottomLeft. I guess something has changed to what tga format is expected by the game and it affects mods.

All I want to know is whether this change will be reverted/fixed in future. Or should we stick to BottomLeft orientation for game icons from now on? (which on other hand would look flipped on the steam_legacy branch).

— Reply to this email directly, view it on GitHub https://github.com/ValveSoftware/halflife/issues/3744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA34IYXDIDOBESEH6TNSWLDYN6JY7AVCNFSM6AAAAABBWA3S7CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TKOJWHE3TENQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>