search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.66k stars 616 forks source link

[GoldSource - Bug] ServerBrowser incorrectly determines the number of players #783

Closed ghost closed 11 years ago

ghost commented 11 years ago

image

xPaw commented 11 years ago

It's displaying players correctly. You're playing on non-steam server.

ghost commented 11 years ago

Maybe it's a non-steam server, but I can't see the difference in ServerBrowser, it's very annoying. And if that's true, that I see incorrect number of players only when a server is non steam, then ServerBrowser is useless, because I have never ever seen the correct number of players

xPaw commented 11 years ago

Look at steamids of players, all of them (except you) are invalid. Server browser doesn't count bots and invalid player.

Freeman-AM commented 11 years ago

no steam = no support ? :D

Keep it like that, it's good that non steam servers don't show real player number on gamebrowser. Only real steam servers will show exact numbers of people so, steam server will be above non steam server in ServerBrowser. And it should stay like that.

ghost commented 11 years ago

@xPaw it is stupid to check status output every time I join a server

Server browser doesn't count bots and invalid player.

Maybe that's the solution? Server browser detects invalid SteamID and ignores the server

Freeman-AM commented 11 years ago

@MaxKorz if he do that maybe it will cause problems with bots like podbot ?

ghost commented 11 years ago

Bots don't use SteamIDS:

] status
hostname:  Counter-Strike 1.6 Server
version :  48/1.1.2.7 5971 secure  (10)
tcp/ip  :  95.28.194.121:27015
map     :  de_dust at: 0 x, 0 y, 0 z
players :  7 active (21 max)

#      name userid uniqueid frag time ping loss adr
# 2 "[P*D]Stacy_Keech (100)" 2 BOT   0 01:17    0    0
# 3 "[P0D]Wesley_Snipes (100)" 3 BOT   1 01:17    0    0
# 4 "[POD]Joe_Pesci (100)" 4 BOT   0 01:17    0    0
# 5 "[P*D]Cheech Marin (100)" 5 BOT   0 01:17    0    0
# 6 "[P*D]Adam_Sandler (100)" 6 BOT   0 01:17    0    0
# 7 "[P0D]Pseudolukian (100)" 7 BOT   2 01:17    0    0
# 8 "NeoXidizer" 9 STEAM_0:1:29437217   0 00:08    6    0
7 users
alfred-valve commented 11 years ago

The main serverbrowser list does not include bots in its player count, the game info dialog (that uses a different query) does.

ghost commented 11 years ago

@alfred-valve read the discussion again, it's not about bots. Serverbrowser list doesn't show all players ( they're not bots )

xPaw commented 11 years ago

It doesn't show these players, because they don't have valid SteamIDs, I already explained that.

alfred-valve commented 11 years ago

Right, as @xPaw said, steam sees those users as bots as they aren't legitimate steam users.