ValveSoftware / halflife

Half-Life 1 engine based games

Other

3.74k stars 631 forks source link

Apply bugfixes to all GoldSource mods #883

Open ghost opened 11 years ago

ghost commented 11 years ago

Some bugfixes are not applied to GoldSource mods:

Fix for https://github.com/ValveSoftware/halflife/issues/200 (hud_fastswtich 0-2) works only in CS and CS:CZ
Fix for https://github.com/ValveSoftware/halflife/issues/809 (door entities sound bug) works only in Half-Life
~~motd.txt https://github.com/ValveSoftware/halflife/issues/221 is updated only in Counter-Strike (tell me, if you need some help with it)~~
~~Fix for https://github.com/ValveSoftware/halflife/issues/560 (v_angle are changed after closing "Options Menu") is not applied to DeathMatch Classic and TFC. Video: http://youtu.be/YtYEleSf5As~~
~~.bmp snapshots #681 don't work in software mode~~

alfred-valve commented 11 years ago

Fix for #560 is live now. #681 is an engine thing and should just work across all mods also.

200 is game specific and I am not sure if it is appropriate for each game (so I won't add that).

MOTD's, looks like only DoD needs the tweak. The door fix could spread around some more.

ghost commented 11 years ago

sure, it's working across all mods, I meant renderer mode. It works in OpenGL, but not Software

.pcx file: (created with screenshot) .bmp file is corrupted and when I try to take a snapshot in game menu, game crashes

how it should look

200 is useful for mods without multi weapon select (TF:C, DOD,DMC)

MOTD. CS:CZ original https://gist.github.com/MaxKorz/9a1d9efa0cdb977f0ce5#file-original-html suggestion https://gist.github.com/MaxKorz/9a1d9efa0cdb977f0ce5#file-suggestion-html

and you have a bug in cstrike MOTD, body tag is not opened original https://gist.github.com/MaxKorz/d1779fce79f7191c7a3d#file-original-html suggestion https://gist.github.com/MaxKorz/d1779fce79f7191c7a3d#file-suggestion-html

DOD: original https://gist.github.com/MaxKorz/7e42a0563f60ab5eddc9#file-original-html suggestion https://gist.github.com/MaxKorz/7e42a0563f60ab5eddc9#file-suggestion-html

alfred-valve commented 11 years ago

Those motd's look reasonable, I'll get them pulled over.

.pcx is NOT a .bmp file, you can't just rename it. That said I have no idea what would display a pcx file in this day and age, so I'll just change the snapshot command in software to put out a bmp anyway.

ghost commented 11 years ago

I know that .pcx is not a .bmp file :) in opengl mode snapshot creates normal .bmp files, screenshot - normal .tga files in software mode snapshot creates corrupted .bmp files, screenshot - distorted .pcx files

alfred-valve commented 11 years ago

Oh yeah, well I'll move over the snapshot fix and change the pcx to tga output for screenshot.

Yulike commented 11 years ago

alfred-valve: Can you add #200 too all games but under "hud_fastswitch 3" while 0 & 1 maintain original functionality. I got accustomed to it and miss it while playing DOD and TFC.