ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.67k stars 621 forks source link

[TFC] Nail grenade brush exploit. #993

Open hlstriker opened 11 years ago

hlstriker commented 11 years ago

When a nail grenade is about to start throwing nails it will first pop itself into the air a little bit. When this happens it can actually set its origin into a solid brush. When it’s in a solid brush it seems to do a lot more damage (unless that’s just me, never actually tested), and it will also do damage to people on all sides of that brush. For example a soldier can go under the sniper deck on 2fort and time a nail grenade perfectly so it pops up into the ceiling. This ceiling is also the floor for the sniper deck. So it will do damage to all players above and below the sniper deck. I fixed this by blocking the “pop up” origin change if the new origins pointcontents are solid.


If you ever want someone to maintain all aspects of TFC for free please feel free to contact me!

kriswema commented 11 years ago

This also applies to MIRV grenades.

http://youtu.be/ZaKFGpIrl_4?t=30s 0:30 - 1:38

hlstriker commented 11 years ago

A better video view: http://www.youtube.com/watch?v=pAbTR3cWEVY

pizzahut2 commented 5 years ago

@mikela-valve Any chance to fix this bug? Currently a third-party plugin is needed.

Here's @hlstriker's TFC bug fix compilation for AMX Mod X: https://forums.alliedmods.net/showthread.php?t=297514

SamVanheer commented 5 years ago

Looks like the problem is in CTFNailGrenade::Explode. It's performing a trace upwards by 32 units and sets the origin to the trace end position. Somehow this ends up inside brushes.

hlstriker commented 5 years ago

Here's @hlstriker's TFC bug fix compilation for AMX Mod X: https://forums.alliedmods.net/showthread.php?t=297514

Keep in mind some of those fixes were written for bugs that are now fixed by valve. Also, I'm pretty sure the okapi module isn't stable and can crash the server (so I've been told), and that is used for bug fix 14 and 15 (see the plugin description) from what I remember.

pizzahut2 commented 5 years ago

@hlstriker You mentioned in the starting post that you fixed this bug in 2013, so 4 years before aforementioned AMXX plugin. Is there another plugin available which doesn't use "okapi"? Not counting Sparky Utilities or my own plugin.

hlstriker commented 5 years ago

Here is a stripped down version: https://pastebin.com/raw/d04QVY1p