search

ValveSoftware / openvr

OpenVR SDK
http://steamvr.com
BSD 3-Clause "New" or "Revised" License
6.14k stars 1.28k forks source link

Update openvr_driver.h to IVRSettings_002 #276

Open mncharity opened 8 years ago

mncharity commented 8 years ago

On September 8, there was a SteamVR release[1], with associated Steam OpenVR depot updates. Its new driver_lighthouse.so supports only IVRSettings_002.[2] The current openvr headers/openvr_driver.h[3] is still July's OpenVR SDK 1.0.2, with only IVRSettings_001.

IVRSettings_001 is not compatible with IVRSettings_002. A core dump results from mixing them. It looks like a method offset change (eg, I see GetString being used to fetch ipd, instead of GetFloat).

Can we get a current openvr_driver.h?

Thanks. And thanks to @rpavlik [4].

[1] "SteamVR Updated (1473196558)". [2] strings ~/.steam/steam/steamapps/common/SteamVR/drivers/lighthouse/bin/linux64/driver_lighthouse.so |grep Settings_0 yields IVRSettings_002. [3] https://github.com/ValveSoftware/openvr/blob/b20b25705d8dd82be221fe68a61db36ae7e2608e/headers/openvr_driver.h#L1188 . [4] https://github.com/OSVR/OSVR-Vive/issues/20#issuecomment-249895991

lonqq commented 8 years ago

Same thing with DriverDirectModeComponent, which was updated to 002 in beta version. New version of openvr_driver.h would be very helpful.