xrEnumerateViveTrackerPathsHTCX results are not used

ValveSoftware / openxr_engine_plugins

Contains Valve-provided plugins for using OpenXR extensions with various game engines

BSD 3-Clause "New" or "Revised" License

50 stars 15 forks source link

xrEnumerateViveTrackerPathsHTCX results are not used #2

Open RemiArnaud opened 2 years ago

RemiArnaud commented 2 years ago

https://github.com/ValveSoftware/openxr_engine_plugins/blob/272c1470b95677f6dd131e4d707ffa985fab1ffb/unreal_engine/ue4/OpenXRViveTracker/Source/OpenXRViveTracker/Private/OpenXRViveTracker.cpp#L200

I was wondering why calling xrEnumerateViveTrackerPathsHTCX but not using the result.

also, wondering if it is intentional the event XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED (18) is ignored in OnEvent()

1runeberg commented 2 years ago

It was meant for troubleshooting connection issues and as a code sample for devs. There wasn't any need to use the info currently in the way the plugin was designed.

Re: Data session - yes, this was meant only for debugging. But good point, should probably simply put a proper debug level so there's no need to comment out. will make the necc changes. thanks.