ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.8k stars 2k forks source link

ServerBrowser ignores Source SDK 2013 MP appid #132

Closed azuisleet closed 11 years ago

azuisleet commented 11 years ago

The logic inside CBaseGamesPage::CheckPrimaryFilters in the shipped Source SDK 2013 Base and possibly Steam Client includes a filter that discards servers with appids above the shipped source mods on Steam app id range, preventing multiplayer servers from showing on the server browser.

BSVino commented 11 years ago

This is a pretty serious issue for us, I ported our multiplayer only game to 2013 and released a new version this week but nobody can play it for lack of servers in the browser.

jimbomcb commented 11 years ago

Good timing, was minutes away from finishing writing a ticket for this myself. Same our end, the mod simply refuses to list despite definitely being registered with the master server. Pretty big issue, hard to have a MP mod with no servers listing in the Steam & in-game browser (and also having right click-view game info not displaying the server or launching the correct mod)

alfred-valve commented 11 years ago

I have a fix for the in-game browser pending. The Steam server browser does not have this bug and works for my testing. Can you provide a sample gameinfo.txt that fails to list in the steam serverbrowser properly please.

BSVino commented 11 years ago

Here's mine: http://codepad.org/0XLVTKk6

I can confirm that I can see a lan server in the steam browser that I can't see in the in-game browser, but not in Internet.

Thanks for the help, we're all eager to play the SDK 2013 port of our games.

azuisleet commented 11 years ago

For a mod which I've named "sdk2013", I see the same behavior in the Steam browser, in which the server will not show up on the Internet tab. I use the gameinfo.txt supplied with the SDK except that I've renamed "hl2mp" to "sdk2013" for game paths.

alfred-valve commented 11 years ago

Okay, I believe I see the steam issue and that should be fixed now (your server may have to restart). The in-game listing issue still needs a code update before it is fixed.

azuisleet commented 11 years ago

Just want to double check: I see the server returned in the GMS query issued by the Steam Client, but there's still a filter preventing from being shown in the (Internet) Servers window which I have not checked yet. From the way you described it, it was something you changed on your end?

BSVino commented 11 years ago

I've restarted my server but I still don't see it in the Steam client Internet tab, but I do see it in the LAN tab.

alfred-valve commented 11 years ago

Actually, there is another bug causing these mods not to list, and that needs a steam client fix sorry. Soon, we will have a fix live soon :)

BSVino commented 11 years ago

Horay, thanks Alfred!

caposguanatos commented 11 years ago

In the dev console you can see this when querying the server from steam browser..

Bad connectionless packet ( CL 'I' ) from loopback.

Dementei commented 11 years ago

Any updates on this?

alfred-valve commented 11 years ago

The Steam client beta that went live yesterday contains this fix, so opt into the Steam client beta and you should be good. There is still the code issue in the server browser in the game itself that is still pending release.

Dementei commented 11 years ago

Gotcha, just tried the Steam client beta server list and it does work. Hope for the engine fix soon, thanks.

-Edit, had the wrong version of the mod filtered, the server list on Steam and in-game do not seem to work. Anyone else want to verify?

BSVino commented 11 years ago

Negative, I downloaded the Steam client beta and I couldn't see my mod's servers in there either, although I do see them in the LAN tab. In other words, no change for me.

As a workaround, I wonder if it's possible to use the steam://connect/123.123.123.123:27015 URL to make a server list manually? I tried it, but instead of opening my mod, Steam opens "Source Engine Test", the SDK base without the mod loaded.

jimbomcb commented 11 years ago

Yeah, servers our end are still being filtered by Steam despite being listed on the master server

We also get the same behaviour where direct connecting through steam (or view game info -> join game) will launch sourcetest rather than the appropriate mod (and it refuses to list any information about the server).

jan-h commented 11 years ago

The Steam beta update fixed Source 2007 games not being listed in the Steam server browser while they were always listed in the in-game server browser. When checking the game server reply you see that Source 2007 servers report the AppID 218. Source 2013 MP servers on the other hand report AppID 0. I believe this is the reason why both the Steam server browser and the in-game server browser filter out Source 2013 MP servers. I can also still reproduce the issue with double-clicking a LAN server from the server browser. It opens sourcetest instead of the actual mod, which was working back then with Source 2007.

JoeLudwig commented 11 years ago

This should be entirely fixed with today's SDK and SDK Base updates. Please let us know if it isn't.

jan-h commented 11 years ago

I'm afraid to report that even though everything is up to date on my system, this issue is not fixed.

JoeLudwig commented 11 years ago

There was a mod compatibility issue with the new SDK drop. While I'm working on that I rolled back the SDK Base and added the new version as a beta called "upcoming". Is it fixed if you opt-in to the beta?

jan-h commented 11 years ago

Our game crashes to the desktop with the "upcoming" beta. I'll see if I can do something about that, otherwise I'll test again once the compatibility issues are fixed and the update is live.

JoeLudwig commented 11 years ago

Please try again with the "upcoming" beta now that the compat issue is fixed.

BSVino commented 11 years ago

Confirmed fix when using "upcoming". Is there a timetable for "upcoming" to be promoted?

Also, can we get that same fix for the Steam server browser as well?

jan-h commented 11 years ago

The in-game server browser shows my dedicated server now, doesn't matter if it's an Internet or LAN server, it's shown on both tabs. The Steam server browser is a different story, but I guess this one's fixed now.