ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.76k stars 2k forks source link

vbsp issue: Empty worldspawn when using a map manifest. #328

Open maxdup opened 9 years ago

maxdup commented 9 years ago

Vbsp makes an empty worldspawn when fed with a vmm file. The resulting worldspawn has none of the essential values you would expect from a worldspawn such as "skyname" or "detailvbsp".

I'm not fluent in c++, but I think the problem is around src/utils/vbsp/manifest.cpp, line 301. An empty worldspawn is created but nothing is done to it as far as I can tell. values should probably be taken from the primary or toplevel map.

(the tf2 toolset would benefit from fixing this)

bmk10 commented 8 years ago

cool... , have u tried to vbsp .cpp ?

DeathByNukes commented 6 years ago

This seems to fix the problem: https://github.com/DeathByNukes/source-sdk-2013/commit/2f915b95a37be42231fef3a0502ea73c045f1656 I've only tested this in one Source game though.

maxdup commented 6 years ago

@DeathByNukes Nice! this should do it. I'll test that out when I find the time