search

ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.8k stars 2k forks source link

Choppy player animations in MP #35

Open TurboBroadway opened 11 years ago

TurboBroadway commented 11 years ago

It seems that Source 2013 MP is no longer using HL2MPPlayerAnimState. Without it, player animations are choppy and left unpredicted.

While this is an easy issue to fix, I still think it should be reimplemented again.

ImperialCommunity commented 11 years ago

So implement it and do a pull request or what are you doing with source code in the first place..

TurboBroadway commented 11 years ago

I did, for my own project.

ImperialCommunity commented 11 years ago

Valve has changed the licensing for this SDK so people can contribute back to the modding community directly with pull requests, so it would be incredibly nice if the community embraced this.

droidmonkey commented 11 years ago

@ImperialCommunity [edited for rudeness, sorry] not every issue needs to be a pull request. This one requires some answers from Valve prior to work being performed.

Onto the issue at hand. I noticed while doing my merge into my mod that the ***PlayerAnimState was removed from everything. It could be that they implemented a new system and a flag was not set correctly, or this really is in error. It deserves an answer from Valve prior to work being performed.

ImperialCommunity commented 11 years ago

Not being rude, but your comment was.

Don't be so ignorant. Just because I don't use github, doesn't mean I don't know anything. Bitbucket is better anyway. Only joined github literally for this project.

If you have such "evidence of knowledge" then I would assume you wouldn't assume things about people on the internet over one small comment. Then again, you're probably a socialist hipster type and think you know everything about everyone through 1 comment, and think you can tell people what to do and what not to do, and then tell them not to tell others what to do in direct contradiction.

Inb4 I'm scolded by "daddy" for this reply defending myself against a cyber-bully.

TurboBroadway commented 11 years ago

It seems to me that parts of Source 2013 MP come straight from Source 2006 MP. Which could be why HL2MPPlayerAnimState wasn't implemented.

EDIT: @ImperialCommunity, please don't treat Github like a forums. Disrespecting other users will not solve anything. Instead, why don't you try fixing this bug and making a pull request yourself? It honestly is a very easy issue to fix.

JoeLudwig commented 11 years ago

I'm not sure which class you're talking about, @Violent . HL2MP uses CPlayerAnimState, which is defined in hl2mp_player_shared.* and is only used in hl2mp. I don't see HL2MPPLayerAnimState in the code anywhere.

What would your fix be?

sswires commented 11 years ago

@JoeLudwig The class was a part of the SDK when Tony Sergei was responsible for it many moons ago.

Another regression with this SDK is that it doesn't include his mod template either.

JoeLudwig commented 11 years ago

The mod template broke with multiple platforms (and would have broken again with the VPC change), so it was left out intentionally.

What's the exact name of the class? I'm trying to track it down, but I'm not sure what to search for.

tonysergi commented 11 years ago

game\shared\hl2mp\hl2mp_playeranimstate.cpp/h which relies on game\shared\multiplayer\multiplayer_animstate.cpp/h