search

ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.73k stars 1.99k forks source link

Fixed a compilation error in VS2015. #395

Closed PazerOP closed 7 years ago

PazerOP commented 7 years ago

Fixed ambiguous call to abs()

filipopo commented 7 years ago

is the code now fully compatible with VS2015 and backwards compatible with VS2013?

joeangry commented 7 years ago

It can't be until Valve releases updated libraries for things we don't have the source code for. It might compile fine but it won't link as far as I know.

filipopo commented 7 years ago

damn, forgot about that.. well we're doomed until source 2, nothing new

joeangry commented 7 years ago

So exactly what is the point of your commits @PazerOP?

sergeysova commented 7 years ago

@PazerOP Maybe squash all your commits in one?

PazerOP commented 7 years ago

What the fuck, why did all these commits get added to this pull request??? Really sorry about that. @LestaD not sure these should be approved, some of these things (that I did specifically chose NOT to add to the original pull request) are only valid in VS2015 and won't compile on earlier versions.

Is there any way I can delete this broken pull request? Can't seem to find the option.