ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.72k stars 1.99k forks source link

engine/buildcubemaps.cpp for Pbr rendering. #408

Open k0091601 opened 7 years ago

k0091601 commented 7 years ago

As buildcubemaps.cpp isn't included in the current sdk it is impossible for 2013 to support a fully physically based rendering pipeline. Cubemaps would require additional prefiltering.

When considering your next update, Could we see the ability to resample/filter cubemaps ? Or could we see cubemap capturing functionality exposed to the client so that we could implement it ourselves? alternatively I could create a pull request that adds the functionality into engine/buildcubemaps.cpp as its pretty straightforward.

Nephyrin commented 7 years ago

We generally don't expose engine source in the SDK, and just buildcubemaps.cpp wouldn't be buildable on its own. Cubemap generation, though, is not terribly complex -- it mostly consists of changing some rendering convars (mostly turning off some props and reflections IIRC), teleporting the camera around, and copying the screen into some textures using the vtex apis. It would likely be easier and more flexible to implement your own system than adapting the (rather aged) engine code for this purpose.

We can keep the issue open for consideration, however.

samzanemesis commented 6 years ago

Hello

I have developed an utility and a library that filters cubemaps and writes the filtered cubemaps to it's mipmap for my project a while ago, I will be cleaning it up and I'll release it soon on github to be easy to integrate in other projects, I'll attach it to this issue once this happens

mloccy commented 5 years ago

@samzanemesis any luck with that so far? Could really use that for a project I'm contributing to.