PVS-Studio: V523 The 'then' statement is equivalent to the 'else' statement.

[SviatoslavRazmyslov]

We have found bugs using PVS-Studio tool. PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/

void CTriggerWateryDeath::StartTouch(CBaseEntity *pOther)
{
  ....
  // Always added to the end
  // Players get warned, everything else gets et quick.
  if ( pOther->IsPlayer() )
  {
    m_flEntityKillTimes.AddToTail( gpGlobals->curtime + WD_KILLTIME_NEXT_BITE );
  }
  else
  {
    m_flEntityKillTimes.AddToTail( gpGlobals->curtime + WD_KILLTIME_NEXT_BITE );
  }
  ....
}

Analyzer warning:

• V523 The 'then' statement is equivalent to the 'else' statement. hl2_triggers.cpp 752
• V523 The 'then' statement is equivalent to the 'else' statement. npc_ichthyosaur.cpp 724
• V523 The 'then' statement is equivalent to the 'else' statement. weapon_crossbow.cpp 540

We suggests having a look at the emails, sent from @pvs-studio.com.