ValveSoftware / source-sdk-2013

The 2013 edition of the Source SDK
https://developer.valvesoftware.com/wiki/SDK2013_GettingStarted
Other
3.69k stars 1.99k forks source link

Behavior of "cc_captiontrace" does not match documentation when set to "2" #545

Closed lunalucadou closed 2 years ago

lunalucadou commented 2 years ago

Per https://developer.valvesoftware.com/wiki/Console_Command_List#Commands_starting_with_letter_.22C.22 the behavior of cc_captiontrace should be:

Show missing closecaptions: (0 = no, 1 = devconsole, 2 = show in HUD)

However, in practice, missing captions are only printed to the console.

According to an archived version of the wiki, this behavior is not new: it was specified in the wiki all the way back in 2006.

In Source SDK 2013, this bug is present in at least two places:

There is likely a buggy input validation check prior to this since cc_captiontrace 2 should cause the initial <2 check to fail and print no missing caption errors, but in any case, even if there was no input validation error to begin with, there is no logic to print missing caption errors to the HUD. I searched this repo for cc_captiontrace and those were the only two results, so I expect this bug also involves some upstream code not present in the SDK.

Outside the Source SDK 2013, this bug is also present in Half-Life 2, HL2 Episode 1, and HL2 Episode 2, so this bug appears to have been around for some time. It is also present in Black Mesa, which (according to one of the Crowbar Collective team members) uses a modified version of the TF2 SDK.

I understand this is a very old codebase and this is a very obscure issue, but I have been documenting a lot of caption issues in Black Mesa, and this being fixed would make my life a lot easier since I wouldn't have to open the console to figure out if a caption didn't trigger or if a sound just doesn't have an associated caption.

lunalucadou commented 2 years ago

I have just confirmed this is not just a bug, but a regression.

Using Half-Life 2 Old Engine (from SourceRuns), which uses Source SDK 2006, I found that cc_captiontrace 2 used to work as described:

image

image

This behavior would be quite useful for my Black Mesa captioning work.

kisak-valve commented 2 years ago

Hello @lunalucadou, there's no real value in duplicating the same information over multiple issue trackers. Closing in favor of https://github.com/ValveSoftware/Source-1-Games/issues/3946.

weaponcubemap commented 1 year ago

Nobody cares about duplicates, people want to get shit fixed...

Kefta commented 1 year ago

I care, thank you for closing this duplicate.