ValveSoftware / steam-audio

Steam Audio
https://valvesoftware.github.io/steam-audio/
Apache License 2.0
2.2k stars 152 forks source link

STEAMAUDIO_VERSION uses uint32_t instead of IPLuint32 #320

Closed Redhacker1 closed 3 months ago

Redhacker1 commented 3 months ago

System Information Please provide the following information about your system:

Issue Description STEAMAUDIO_VERSION should be using IPLuint32 instead of uint32_t (example:) https://gist.github.com/Redhacker1/b3f9a8daa62dbbb2e8f1e51ff3d352ad

A similar issue was fixed a week ago (https://github.com/ValveSoftware/steam-audio/commit/bab44824f5f3ca887ea8d660688fb5299965e0cf), because of that, I don't expect it to be unreasonable, making the change locally the project seems to build and the tests from what I can tell all pass just the same and #include <stdint.h> is not necessary.

Redhacker1 commented 3 months ago

Something I removed because my reasoning for why it was there must not have been correct, although should be something to note: I am not sure #include <stddef.h> in phonon.h is necessary either, at least on my end (note I am not using intel oneapi so if it is needed there)

I am however using windows and MSVC and that does have a habit of including more "things" by default that GCC later complains do not exist. so I am more inclined to ignore it.

wolframw commented 3 months ago

@Redhacker1 stddef.h is needed because it contains the definition of size_t. If you include any headers before phonon.h on your end, there's a good chance that stddef.h is already transitively included by some other header further up.

Redhacker1 commented 3 months ago

That's more than likely what's going on.

As I said I wasn't really going to push that. I've had incidents where things like that happen.

My bigger thing is that It should be using SteamAudio types for the version rather than uint32_t